1702985 - Update Bookmarks folder icon

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

This icon is used in the Bookmarks native menu, the Bookmarks toolbar, the Bookmarks Toolbar menu, the Bookmarks Panel, the Bookmarks Modal, and the Library. It might be used elsewhere.

During their review of the global native menubar, UX flagged this icon for being updated.

Comment 1

[Romain Testard [:RT]]

Making it a P1 given it's icon work

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This icon is browser/themes/shared/places/folder.svg, which is marked as "no changes planned" in the spreadsheet. Can I presume we should just be using folder.svg here?

Comment 3

[Sam Foster [:sfoster] (he/him)]

We don't have all the new icons that would allow use to update the places UI. They are visually quite different to our current photon icons; we decided to leave these alone for now rather than have an inconsistent/patchy experience here.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Okay, so it sounds like we aren't planning on getting a new icon here. So I guess we should deprioritize this one?

Comment 5

[Romain Testard [:RT]]

Which ones in particular are missing?
ccing Emanuela and Katie for visibility

Comment 6

[Sam Foster [:sfoster] (he/him)]

There's a set of places icons which show up in the places (all bookmarks etc.) dialog. These pre-date even photon/57, and in the path->icon tracking spreadsheet the decision was to not update them. But, as :mconley points out, its complicated as these icons show up in other places too. The full set of places-specific icons are:

• browser/themes/shared/places/bookmarksToolbar.svg
• browser/themes/shared/places/folder-smart.svg
• browser/themes/shared/places/bookmarksMenu.svg
• browser/themes/shared/places/tag.svg
• browser/themes/shared/places/history.svg
• browser/themes/shared/places/folder.svg

If/when we pick this up, there's a https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE which provides links to where to find the new icon assets, suggested procedure and the referenced tracking spreadsheet for icon updates.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

All of the icon paths listed in comment 6 are "no changes planned" in the spreadsheet with the latest icon dump. Given that we should have all of the icons now, can I presume this isn't something that needs to block MR1?

Comment 8

[Sam Foster [:sfoster] (he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #7)

All of the icon paths listed in comment 6 are "no changes planned" in the spreadsheet with the latest icon dump. Given that we should have all of the icons now, can I presume this isn't something that needs to block MR1?

I think that's right. We don't have - and aren't expecting - new icons for at least smart folders and tags, and its not clear to me which icon bookmarks folder would use. Probably just bookmarks.svg.. But if its possible to not do this, I would prefer to de-prioritize. If we're basically committed already, lets figure out a plan.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Over to rtestard to consider reprioritization then.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Alright, let's consider this a P1 still, I guess.

The new asset doesn't look that out of place in the Library. Maybe we can get away with a drop-in replacement.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1702985 - Update bookmarks folder icon. r?sfoster!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0d9dad38647
Update bookmarks folder icon. r=sfoster,desktop-theme-reviewers,harry

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a0d9dad38647

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9218448 [details]
Bug 1702985 - Update bookmarks folder icon. r?sfoster!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Asset swap for new Proton icon.
• String changes made/needed: None.

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218448 [details]
Bug 1702985 - Update bookmarks folder icon. r?sfoster!

Approved for 89 beta 6, thanks.

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ea9348e2083

Comment 17

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,
Can I get the right link for https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE mentioned in Comment 6 please? I'm being redirected to a "page not found"

Also from this list:
browser/themes/shared/places/bookmarksToolbar.svg
browser/themes/shared/places/folder-smart.svg
browser/themes/shared/places/bookmarksMenu.svg
browser/themes/shared/places/tag.svg

These two are throwing 404 not found :
browser/themes/shared/places/history.svg
browser/themes/shared/places/folder.svg

Thanks in advance!
Best,
Clara

Comment 18

[Sam Foster [:sfoster] (he/him)]

(In reply to Clara Guerrero from comment #17)

Hi,
Can I get the right link for https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE mentioned in Comment 6 please? I'm being redirected to a "page not found"

I've invited you.

These two are throwing 404 not found :
browser/themes/shared/places/history.svg
browser/themes/shared/places/folder.svg

These were already removed in bug 1709445 and bug 1707690