1703002 - Name field in the Bookmarks Panel scrolls to the end by default

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Go to a website with a long-ish title
2. Click on the Bookmark button in the URL bar to open the Bookmarks Panel

ER:

The "Name" input field should be selected, and the beginning of the tab title should be seen

AR:

The "Name" input field is selected, but the field has been horizontally scrolled to the end so that the end of the tab title is seen.

Comment 1

[Tyler Duzan]

Noticed this in my PM review. There are a lot of websites with very long "Title" fields for SEO purposes and this was confusing when I first saw it before I realized what was happening. I'd like to see this fixed before we ship if possible for polish, so I am marking this as 2a.

Comment 2

[Neil Deakin]

Attachment: Bug 1703002, don't scroll when focusing the textbox in the edit bookmark panel, r=mak

Note that Element.select() always focuses the element without scrolling, so the call to focus()
is redundant, but we'll leave it in anyway in case that changes.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I love how this bug page itself can be used to reproduce its reported issue!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a12143b2e10b
don't scroll when focusing the textbox in the edit bookmark panel, r=mak

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a12143b2e10b

Comment 6

[Ciprian Georgiu, Desktop QA]

We've verified this fix using latest Beta 89.0b3 under macOS 10.15, Ubuntu 18.04 x64 and Win 10 x64.