1703027 - Update icons on about:newtab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

We have updated icons for use on the new tab page.
Please see the procedure doc which has details on where to find the new icons, how to put together the patch and verify the result.

Comment 1

[Bernard Igiri]

Attachment: Bug 1703027 - Update icons on about:newtab r=sfoster,mardak

Updated icons, skipped delete.svg, delete-20.svg, and edit.svg as I could not find these icons on Google Drive.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87a78e0df6cb
Update icons on about:newtab r=sfoster,Mardak

Comment 3

[Bernard Igiri]

Comment on attachment 9219008 [details]
Bug 1703027 - Update icons on about:newtab r=sfoster,mardak

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Check that the icons in new tab, in Top Sites, and the UI accessible from the "..." menu when hovering over Top Sites has been updated to the new Proton icons.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Icon changes only.
• String changes made/needed:

Comment 4

[Bernard Igiri]

These icons can be found in the newtab page in the following locations:

• In Top Sites a search icon should be overlaid on the search provider icons.
• In Top Sites when you hover over an icon the menu should provide edit and delete options. In edit the second input field has an icon. In delete there should be an icon in the modal dialog.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/87a78e0df6cb

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219008 [details]
Bug 1703027 - Update icons on about:newtab r=sfoster,mardak

Approved for 89 beta 7, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/724edf589b13

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

The icons for the context menu for different items (top site tiles, pocket cards) are removed per bug 1681482. This has been verified using Fx89.0b11 and latest Fx90.0a1 on Windows 10 and Ubuntu 18.04.