Closed Bug 1703028 Opened 3 years ago Closed 3 years ago

[Proton] Fix spacing in JS and Firefox new in-content-area modal dialogs, take #42

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Desktop
All

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-modals] [priority:2a])

Attachments

(1 file)

It's supposed to be 16px everywhere, but:

  • the sizing of the title element from adjustableTitle.js increases the height of the label, which creates 2px extra spacing on either Windows or macOS (don't recall as I'm writing this)
  • the margins around the checkbox element impact spacing (ensure you check after bug 1700141 has landed)
  • the checkbox itself has too much inline spacing between the checkbox and the label (should be 8px total) because the 0-width unused checkbox-icon and the checkbox label have 2 and 4px inline margin, with another 6 on the checkbox-check. We should probably remove the 4px inline start margin on the label.

In no particular order, this fixes:

  • alignment of the title text when using adjustableTitle, and avoids
    increasing the height of the text container to 1.5em
  • horizontal sizing of buttons (the mocks have the buttons without any
    minimum width)
  • horizontal spacing between the checkbox and its label
  • vertical spacing of checkboxes as compared with other UI elements
  • hiding the login label when displaying a prompt() dialog (it's empty).
  • displaying the infoBody right next to the prompt input field as the
    design specifies, and encoding this relationship with an aria-labelledby
    attribute.
Priority: -- → P2
Whiteboard: [proton-modals] → [proton-modals] [priority:2a]
Attachment #9213641 - Attachment description: Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley → WIP: Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley
Attachment #9213641 - Attachment description: WIP: Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley → Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley
Blocks: 1700641
Blocks: 1704298
Attachment #9213641 - Attachment description: Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley → WIP: Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley
Attachment #9213641 - Attachment description: WIP: Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley → Bug 1703028 - fix spacing and sizing of various parts of modal dialogs in proton, r?mconley,mtigley
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69d3088f0fd4
fix spacing and sizing of various parts of modal dialogs in proton, r=mconley,mtigley
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1706567
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: