1703043 - Find bar checkbox labels should use different colour (#5b5b66 on light, #bfbfc9 on dark)

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[:Gijs (he/him)]

These colours are specced but we haven't yet implemented them. Doing so might be tricky given a variety of background on which the label text can appear.

Comment 1

[:Gijs (he/him)]

bug 1705882 is fixing this.

Comment 2

[Ed Lee :Mardak]

Bug 1699550 approximated the different color with opacity for doorhangers.

Comment 3

[Ed Lee :Mardak]

The dependent bugs so far have adjusted the colors for modals and panels. There are other places that have not been updated like infobar/findbar and in-content pages -- although unclear if it's desired to change the colors for about:preferences as the checkbox+label can be the main thing to interact with.

So maybe just findbar for now?

Unclear if it's useful to have a var with fallback 30% transparency, e.g.,

color: var(--checkbox-label-color, color-mix(in srgb, currentColor 70%, transparent));

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1703043 - Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao!

Add --checkbox-label-color to share with panels and findbar.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbae5e36471b
Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao,emalysz,harry

Comment 6

[Atila Butkovits]

Backed out for casuing failures at browser_ext_themes_findbar.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f8cb1694d6629d9b3b084f109ee5236d4df2956c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Vuk2Qn-mRaK1RrXIbb2Xjw.0&revision=fbae5e36471be40a6730404de68d4ee161790f5d&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-e10s%2Cbc4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337881421&repo=autoland

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99c997f0f0c0
Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao,emalysz,harry

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/99c997f0f0c0

Comment 9

[Ed Lee :Mardak]

Comment on attachment 9217327 [details]
Bug 1703043 - Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao!

Beta/Release Uplift Approval Request

• User impact if declined: Wrong colors for proton findbar text/buttons/checkboxes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open find bar

2. See appropriate colors (slightly lighter than regular toolbar/bookmark toolbar text)

• List of other uplifts needed: Maybe bug 1705849 and bug 1703957 as they touched adjacent lines
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS / theme-json color changes
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217327 [details]
Bug 1703043 - Update findbar labels and placeholder to be appropriately transparent for light and dark r=dao!

Approved for 89 beta 6, thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f611c3de745

Comment 12

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming as verified fixed on 90.0a1(20210505215208) and 89.0b8(20210504185920). Verified using macOS 11, Win10x64 and Ubuntu 20.