Closed Bug 1703051 Opened 3 years ago Closed 3 years ago

Bookmarks Toolbar menupopups should look more like panels with Proton enabled

Categories

(Firefox :: Bookmarks & History, task, P2)

Product:
Firefox
Component:
Bookmarks & History
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 92+
firefox92 --- verified

People

(Reporter: mconley, Assigned: emmamalysz)

References

(Blocks 2 open bugs, Regressed 2 open bugs)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers] [priority:2a])

Attachments

(1 file)

Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar
48 bytes, text/x-phabricator-request
Details | Review

This is similar in a way to bug 1699532, since both deal with menupopup stylings. I'm filing this separately to make sure that the bookmarks toolbar case is explicitly called out, because I know UX really cares about it.

Priority: -- → P3
Blocks: 1706684
Blocks: 1706685

Bumping this to P2A after discussions with Mike Conley. This is a broader set of work, but directly ties to the asks in 1706684 and 1706685

Priority: P3 → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [priority:2a]
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Blocks: 1698761
Attachment #9219308 - Attachment description: Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar → WIP: Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar
Attachment #9219308 - Attachment description: WIP: Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar → Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar
Blocks: 1714041
Blocks: 1714821
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fce7b9d54faf
apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar r=desktop-theme-reviewers,mconley,jaws,harry

Backed out changeset fce7b9d54faf (Bug 1703051) for failures on browser_parsable_css.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/5e7d1891637b4cefcfcb304c10d97f19a8635b6c
Push with failures, failure log

Flags: needinfo?(emalysz)
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e5ec8c60805
apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar r=desktop-theme-reviewers,mconley,jaws,harry

https://hg.mozilla.org/mozilla-central/rev/9e5ec8c60805

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Flags: needinfo?(emalysz)

Border disappeared

Release Note Request (optional, but appreciated)
[Why is this notable]: User visible improvement to the macOS experience
[Affects Firefox for Android]: No
[Suggested wording]: The bookmark toolbar menus now follow Firefox visual styles.
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?

Added to the Fx92 beta relnotes.

relnote-firefox: ? → 92+
Regressions: 1720835
Flags: qe-verify+
Regressions: 1725950
Depends on: 1725970
Regressions: 1725970

Verified as fixed on 92b during the PI-1133 testing.

Status: RESOLVED → VERIFIED
status-firefox92: fixed → verified
Flags: qe-verify+
Regressions: 1730122
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: