1703055 - Remove user/system site-packages from import path when running nativecmds

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement, P2)

Description

[Mitchell Hentges [:mhentges] 🦀]

Including user/system site-packages allows failures when incompatible packages with the wrong versions are on the import path, such as for bug 1702377.

This only affects mach nativecmds, because regular mach commands only have access to their associated virtualenv.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1703055: Don't include global site packages in python path

To avoid erroneously importing a package from the system, we remove
system site package.
This is another positive step towards further insulating the Firefox
build from the state of the environment.

This may cause failures if some mach commands have been sneakily
importing system packages instead of properly vendoring them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/189b85571855
Don't include global site packages in python path r=firefox-build-system-reviewers,glandium,sheehan

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/189b85571855

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for syntax failure (bug 1704838):

https://hg.mozilla.org/mozilla-central/rev/800d0896c6cd6d582c19ca29b0b5a14776cd1ec3

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Patch to resolve this is ready in Phabricator.
I'll land this again after the code freeze.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4d3ba582763
Don't include global site packages in python path r=firefox-build-system-reviewers,glandium,sheehan

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d4d3ba582763