Closed Bug 1703076 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28372 - WebXR: fix getPose() logic

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28372 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28372
Details from upstream follow.

b'Piotr Bialecki <bialpio@chromium.org>' wrote:

WebXR: fix getPose() logic

XRFrame::getPose() should work for spaces when the relationship between
them is known even if we have not received any poses from the device.
This means that getPose(x, x) should return identity, and getPose(x, y)
should also return something if y and x are statically offset from each
other. XRFrame::getViewerPose(viewerSpace) should also follow the same
rules.

Also adds WPT to test the behavior and removes null checks in getPose()
and getViewerPose() - the non-nullability is enforced by the bindings.

Change-Id: If0119c834cfb6e0233d3152b840b0628a571fb4e

Reviewed-on: https://chromium-review.googlesource.com/2803481
WPT-Export-Revision: 054325700a4ed4883b6dc35af9cf78bc423dadc5

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
FAIL : 2

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrFrame_getViewerPose_getPose_identities.https.html: ERROR [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

/webxr/xrFrame_getViewerPose_getPose_identities.https.html: ERROR [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c59a01433bcc
[wpt PR 28372] - WebXR: fix getPose() logic, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1af183a7450e
[wpt PR 28372] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c59a01433bcc
https://hg.mozilla.org/mozilla-central/rev/1af183a7450e

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.