1703082 - [wpt-sync] Sync PR 28373 - Reland "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28373 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28373
Details from upstream follow.

b'Eugene Zemtsov <[e-mail]>' wrote:

Reland "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()"

This reverts commit 823fd0ac1934da06c89a62d46f2fb3850d30f049.

Reason for revert: MSAN failure was caused by another change

Original change's description:

Revert "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()"

This reverts commit 477ea10ee350777a599a4541b6e436ec42563597.

Reason for revert:

It looks like this CL is responsible for breaking the step
"blink_web_tests" on the builder "WebKit Linux MSAN".

First failing build:
https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/9927

Original change's description:

webcodecs: Stop closing frames in Audio|VideoEncoder.encode()

Change-Id: I0281c1bdd836a94f968bf8fdf4fe8d09392845c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803617
Reviewed-by: Thomas Guilbert \<[e-mail]>
Reviewed-by: Chrome Cunningham \<[e-mail]>
Commit-Queue: Eugene Zemtsov \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#869112}

Change-Id: Iacb9e31ff575129a7b320954a5d65dfaf6274b19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2805814
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Fabian Sommer \<[e-mail]>
Auto-Submit: Fabian Sommer \<[e-mail]>
Commit-Queue: Fabian Sommer \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#869156}

Change-Id: Ide12d8cef50e29f35bd52367546475935970b722

Reviewed-on: https://chromium-review.googlesource.com/2804432
WPT-Export-Revision: 0cd21ddb9222bd79af771d9c2505c8b064d31293

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d6d6f7eea904446b930615c9bdb9b354ff3b53d

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 8 subtests

Status Summary

Firefox

OK : 2
FAIL : 17
ERROR: 1

Chrome

OK : 2
PASS : 34
FAIL : 6
ERROR: 1

Safari

OK : 2
FAIL : 17
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/audio-encoder.any.html: ERROR (Chrome: ERROR, Safari: ERROR)
Simple audio encoding: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/video-encoder.any.html
Test VideoEncoder construction: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoEncoder.configure(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful configure(), encode(), and flush(): FAIL (Chrome: FAIL, Safari: FAIL)
Test successful reset() and re-confiugre(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful encode() after re-configure().: FAIL (Chrome: FAIL, Safari: FAIL)
Verify closed VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify unconfigured VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify encoding closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/video-encoder.any.worker.html
Test VideoEncoder construction: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoEncoder.configure(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful configure(), encode(), and flush(): FAIL (Chrome: FAIL, Safari: FAIL)
Test successful reset() and re-confiugre(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful encode() after re-configure().: FAIL (Chrome: FAIL, Safari: FAIL)
Verify closed VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify unconfigured VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify encoding closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4e854b54d79
[wpt PR 28373] - Reland "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()", a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b4e854b54d79