1703169 - XUL buttons labelled by a text child don't expose label for a11y

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[James Teh [:Jamie]]

The new browser info bars (pref: browser.proton.infobars.enabled) contain XUL buttons with no <label> child or label attribute. Rather, they contain a text node set using .textContent. The a11y engine doesn't currently handle this, so these buttons are unlabelled.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1703169: Support XUL buttons labelled by text children.

Previously, text children were excluded from the a11y tree, so they weren't considered when computing name from subtree.

Comment 2

[Mark Striemer [:mstriemer]]

This seems like a useful change, but in bug 1702327 I updated the buttons to set the label rather than textContent. This seems to have fixed bug 1702962 for me, so this likely isn't blocking proton any more.

Jamie, is this still needed for proton?

Comment 3

[James Teh [:Jamie]]

No, it's no longer needed for Proton.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56d5a7ead1f0
Support XUL buttons labelled by text children. r=morgan

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/56d5a7ead1f0