170317 - in nsCRLManager, does it matter if updateURL contains non-ASCII chars?

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Security: UI, defect, P2)

Description

[Kai Engert (:KaiE:)]

in nsCRLManager, in the call to pref->SetCharPref(), does it matter if updateURL
contains non-ASCII chars?

Comment 1

[Kai Engert (:KaiE:)]

This bug was spawned from bug 169932.
Darin, can you please elaborate your concerns?

Comment 2

[Darin Fisher]

alec can probably speak best about the charset issues concerning SetCharPref. 
alec: what happens to non-ASCII characters passed into SetCharPref?  we just
store them as is, right?  if so, then don't we need to worry about what happens
if the user switches locales, or something like that?

Comment 3

[Alec Flett]

ugh. SetCharPref should really only take ASCII, or at the most UTF8. But it
should not hold other charsets...its too bad we didn't have AUTF8String when we
froze this interface, or that is what we would have used.

you should use SetComplexPref() with an nsISupportsString if you need to store
unicode strings...but internally that will just convert it to utf8.

Comment 4

[Stephane Saux]

kai

Comment 5

[Kai Engert (:KaiE:)]

changing obsolete psm* target to --- (unspecified)

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

nsCRLManager is gone.