Closed Bug 1703197 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28379 - Revert "[css-flexbox] Margin collapsing bug in WebKit preventing some flexbox tests from succeeding (#28368)"

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28379 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28379
Details from upstream follow.

b'Sergio Villar Senin <svillar@igalia.com>' wrote:

Revert "[css-flexbox] Margin collapsing bug in WebKit preventing some flexbox tests from succeeding (#28368)"

This reverts commit 33f6a9c72d11a1629d4afa561a83bdf07bf57e89.

All the other engines started to fail after adding the WebKit hack. What's more the hack was working fine for WebKitGtk+ but not for Safari for example. So I'll just revert it and focus on fixing the WebKit bug.

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2487d571d91
[wpt PR 28379] - Revert "[css-flexbox] Margin collapsing bug in WebKit preventing some flexbox tests from succeeding (#28368)", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.