1703291 - Fix dom/base/test/test_window_close.html for Fission+BFCache

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Neha Kochar [:neha]]

Failure log: https://treeherder.mozilla.org/logviewer?job_id=332690237&repo=try&lineNumber=6103

Prefs to set: fission.autostart and fission.bfcacheInParent

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This is because mBrowsingContext->GetIsSingleToplevelInHistory(); is wrong with bfcache enabled, need to dig into how that is computed.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Ok, so in the test there's the following going on: We open a tab, let's call it 1.html, that tab loads a 2.html file via window.location = "2.html", then that second file does history.back(). With bfcache enabled, the three session history entries end up being referring to 1.html, which is obviously wrong.

But then GetIsSingleToplevelInHistory correctly says that there's only one document in session history (but there shouldn't!). So it's a bit of a deeper issue. Will dig more.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1703291 - Update root bc state when the root bc changes in the session history. r=smaug,peterv

Otherwise when navigating to a replaced browsing context we might have
an incorrect "is single top-level in history".

Fixes test_window_close.html with Fission+bfcache.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1703291 - Run test_window_close with bfcacheInParent enabled. r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d244d886aa
Update root bc state when the root bc changes in the session history. r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d216ecbacd9
Run test_window_close with bfcacheInParent enabled. r=smaug

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on BrowsingContext.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/99f36e1fb0dcc2ffacd6e5a4e51e603e09d34960
Log link: https://treeherder.mozilla.org/logviewer?job_id=336021125&repo=autoland&lineNumber=4677

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73004945dd3e
Run test_window_close with bfcacheInParent enabled. r=smaug
https://hg.mozilla.org/integration/autoland/rev/abfde00b3322
Update root bc state when the root bc changes in the session history. r=smaug

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/73004945dd3e
https://hg.mozilla.org/mozilla-central/rev/abfde00b3322