Stop relying on ContentSessionStore for "SessionStore:crashedTabRevived"
Categories
(Firefox :: Session Restore, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: u608768, Assigned: annyG)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
Attachments
(1 file)
See https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/browser/components/sessionstore/ContentSessionStore.jsm#757-773 and https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/browser/components/sessionstore/SessionStore.jsm#1430-1434.
This is only used in the parent process for about:tabcrashed pages.
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
We can probably use chrome-page-hidden / content-page-hidden as a replacement for the "pagehide" event that we're currently relying on (see SessionStore's OBSERVING list). I'm adding a thing in https://phabricator.services.mozilla.com/D110337#C3771309NL72 for SHIP-only SessionStore notifications, so we can probably use the same thing here.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by agakhokidze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bf273f64c48 Stop relying on ContentSessionStore for SessionStore:crashedTabRevived, r=kashav
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
||
Comment 5•3 years ago
|
||
== Change summary for alert #30112 (as of Tue, 18 May 2021 08:02:33 GMT) ==
Improvements:
| Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|---|
| 0.35% | Base Content JS | macosx1015-64-shippable-qr | 2,443,998.67 -> 2,435,372.00 | ||
| 0.26% | Base Content JS | linux1804-64-shippable-qr | 2,437,452.00 -> 2,431,081.33 | ||
| 0.25% | Base Content JS | linux1804-64-shippable | 2,437,208.73 -> 2,431,056.00 | ||
| 0.25% | Base Content JS | macosx1015-64-shippable | 2,440,034.67 -> 2,433,861.33 | ||
| 0.25% | Base Content JS | windows10-64-shippable | 2,447,152.00 -> 2,440,976.00 | ||
| ... | ... | ... | ... | ... | ... |
| 0.22% | Base Content JS | linux1804-64-shippable | 2,437,152.67 -> 2,431,842.67 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30112
|
||
Updated•3 years ago
|
Description
•