170339 - code cleanup: string usage

Status: RESOLVED INVALID

(Core :: Internationalization, defect)

Description

[Shanjian Li]

urg. this patch is bad. it uses AssignWithConversion, which should no longer be
used, and uses nsString as function argument.

It should use a more general type as the argument (nsAString seems appropriate).
as for
+        oCharset.AssignWithConversion("UTF-8"); 

it would be better written as:
oCharset.Assign(NS_LITERAL_STRING("UTF-8"));
which can also be faster, if the compiler supports doing the conversion at
compile time.

oh yeah, one more thing:
+ return oCharset.Length() > 0;

can be written as:
return !oCharset.IsEmpty();

which can be faster.

There are at least 2 places need to be changed. 
nsParser.cpp
mozilla/content/base/src/nsScriptLoader.cpp

Comment 1

[Shanjian Li]

accept

Comment 2

[Rui Xu]

code issue, QA to [e-mail] for now.

Comment 3

[Frank Tang]

shanjian is no longer working on mozilla for 2 years and these bugs are still
here. Mark them won't fix. If you want to reopen it, find a good owner first. 

Comment 4

[Travis Chase]

Mass Re-open of Frank Tangs Won't fix debacle. Spam is his responsibility not my own

Comment 5

[Travis Chase]

Mass Re-assinging Frank Tangs old bugs that he closed won't fix and had to be
re-open. Spam is his fault not my own

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

this doesn't seem relevant anymore.