1703494 - Remove sync layout flush for hamburger menu opening with proton

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[:Gijs (he/him)]

As discussed in bug 1703405, this is a result of the sync item now potentially wrapping and the descriptionHeightWorkaround code running for it. Some options we could investigate to fix it:

1. if we know the width available for the text beforehand (which I think we do, because the width of the panel is fixed?), ensure it is set directly on the element to ensure the XUL code for the preferred height of the element gets it right first time.
2. switch the element in question to an HTML equivalent that wraps (possibly combined with (1)) and ensure we don't hit it in the descriptionHeightWorkAround code.
3. switch everything in the main view to non-XUL flexbox and see if that helps.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

Interestingly, it doesn't even appear that we apply wrapping correctly in the FxA item, even with the descriptionHeightWorkaround. Looks like we truncate the string instead. See screenshot.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1703494 - Use CSS box for FxA CTA item to avoid need for descriptionHeightWorkaround. r?emalysz!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dccfbc75e6ac
Use CSS box for FxA CTA item to avoid need for descriptionHeightWorkaround. r=emalysz

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dccfbc75e6ac