1703508 - Remove flag for large arraybuffers in FF92 or later

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Lars T Hansen [:lth]]

We keep the pref for large arraybuffers at least until FF92, in case something bad happens.

In FF92 or later we can remove it. The fallout of this will also be that some test cases will be updated, and some functions in the runtime can become constants again, and some MOZ_ASSERTS can therefore become static_asserts. ArrayBufferObject::maxBufferByteLength() and ArrayBufferObject::supportLargeBuffers are good places to start.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1703508 part 1 - Remove pref for large ArrayBuffers. r?rhunt!

This shipped in Firefox 89, more than a year ago.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1703508 part 2 - Replace maxBufferByteLength() with MaxByteLength constant. r?rhunt!

Depends on D165027

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1703508 part 3 - Replace TypedArrayObject::maxByteLength() with MaxByteLength constant. r?rhunt!

Depends on D165028

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1703508 part 4 - Rename largeArrayBufferEnabled testing function to largeArrayBufferSupported. r?rhunt!

This testing function is now equivalent to checking whether we're on a 64-bit platform
so it's technically redundant, but it's a bit more descriptive.

Depends on D165029

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e043263b196a
part 1 - Remove pref for large ArrayBuffers. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/3d9440116a22
part 2 - Replace maxBufferByteLength() with MaxByteLength constant. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/597b8afe7562
part 3 - Replace TypedArrayObject::maxByteLength() with MaxByteLength constant. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/729e4c4ef7c8
part 4 - Rename largeArrayBufferEnabled testing function to largeArrayBufferSupported. r=rhunt

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e043263b196a
https://hg.mozilla.org/mozilla-central/rev/3d9440116a22
https://hg.mozilla.org/mozilla-central/rev/597b8afe7562
https://hg.mozilla.org/mozilla-central/rev/729e4c4ef7c8