Open Bug 1703537 Opened 3 years ago Updated 4 months ago

Consider deprecating `pinned` property for pageActions

Categories

(WebExtensions :: Frontend, task)

task

Tracking

(Not tracked)

People

(Reporter: zombie, Unassigned)

References

Details

(Keywords: dev-doc-complete)

See bug 1703274 and https://phabricator.services.mozilla.com/D110998#inline-619101

With the new design, this field will stop doing anything. Communications are planned to developers, and we need to at least document this, if not deprecate it.

Keywords: dev-doc-needed

Gijs, is there any plan or bug to remove pinning from the page action code? If so we could set a blocker for this.

Severity: -- → N/A
Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)

Gijs, is there any plan or bug to remove pinning from the page action code? If so we could set a blocker for this.

I'm not sure I understand the question. With proton enabled, pinning is a no-op. This is shipping as part of 89. We're hoping to remove the relevant prefs (leaving only the proton behaviour) with 90. The relevant metabug is bug 1711506. The WebExtensions framework can do whatever the usual thing is when APIs stop doing something, I guess? I don't know what that is, though. Does that answer your question?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mixedpuppy)

The pinned feature was introduced in bug 1494135 to hide the pageAction button by default (in the meatball menu) for Screenshots (i.e. move to the overflow menu). This is quite a specific use case that probably doesn't need to be supported, especially if users can just hide the button after installation (the cannot easily do that any more, but see bug 1712556).

See Also: → 1494135, 1712556

I mentioned the no-op aspect of the pinned attribute in the 89 release notes and documentation on MDN: https://github.com/mdn/content/pull/5259.

I'm declaring need-info bankruptcy and resetting old ni? on me. If input is still needed on this issue and it is engineering specific for the webextensions team, ni? lgreco, or ni? me again.

Flags: needinfo?(mixedpuppy)
You need to log in before you can comment on or make changes to this bug.