1703588 - FxA toolbar monogram avatar is barely visible while using the browser light theme

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Alin Ilea, Desktop QA]

Attachment: 2021-04-07_16h34_29.mp4

Tested with:

Release 87
Beta 88.0b8
Nightly 89.0a1 (2021-04-07)

Tested on:

Windows 10

Preconditions:

Set up the following prefs in about:config:

• identity.fxaccounts.autoconfig.uri to https://accounts.stage.mozaws.net
• browser.newtabpage.activity-stream.fxaccounts.endpoint to https://accounts.stage.mozaws.net
  -identity.fxaccounts.auth.uri to https://api-accounts.stage.mozaws.net/v1
  -identity.fxaccounts.remote.oauth.uri to https://oauth.stage.mozaws.net/v1
  -identity.fxaccounts.remote.profile.uri to https://profile.stage.mozaws.net/v1
  -identity.fxaccounts.remote.root to https://accounts.stage.mozaws.net/
  -identity.sync.tokenserver.uri to https://token.stage.mozaws.net/1.0/sync/1.5

Steps:

1. Launch firefox and sign in to FxA.
2. Change the browser theme to Light.
3. Click on the FxA toolbar avatar.

Actual result:

The FxA toolbar monogram avatar is barely visible while browser light theme is applied (see the video recording attached).

Expected result:

The FxA toolbar monogram avatar should remains visible.

Note 1: This is not reproducible with context-fill enabled.
Note 2: This is not reproducible in Release 87.

Comment 1

[Alin Ilea, Desktop QA]

Since 87 is not affected I tried to perform the mozregression and I got the following regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e90eebb4095d3fdd9c8b07bf22795eee7c3e9ed6&tochange=c6783cb12c2c5fc5739ed6496d1f3b560dcc091b

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Bug 1698499 or bug 1698416 are the most likely candidates.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I think what we might want to do here is land bug 1699892, and try to get it uplifted if possible. If we can't get it uplifted, then we might want to delay shipping the default avatars, unless Product is okay with a hard-to-see avatar in Light theme.

Let me see if I can get a patch for bug 1699892 put together.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Inverting the dependency, since bug 1699892 seems to fix this.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Now that bug 1699892 is fixed in Nightly, can you confirm on your end that the issue no longer persists?

Comment 6

[Alin Ilea, Desktop QA]

Hi Mike,
Yes, I can confirm that the issue is no longer reproducible in latest Nightly 89.0a1 (2021-04-08).
Thanks!

Comment 7

[:Gijs (he/him)]

Resolving per the comments. :-)