scrollbar-color: <something> transparent prevents scroll arrows from showing up.
Categories
(Core :: Widget: Win32, defect)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
|
Assignee | |
Comment 1•3 years ago
|
||
data:text/html,<html style="scrollbar-color: grey transparent"><div style="height: 200vh">
|
|
Assignee | |
Comment 2•3 years ago
|
||
This improves the rendering of youtube.com on Windows, and I think should be uncontroversial.
scrollbar-color: transparent transparent will still get you the fully transparent scrollbar.
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47b38a36e71a When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl
|
||
Comment 4•3 years ago
|
||
Backed out for causing bustages at nsNativeBasicThemeGTK.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/9fa62e10d8507581d20349bfa9229f7ae5e1cdf2
Failure log: https://treeherder.mozilla.org/logviewer?job_id=335768513&repo=autoland&lineNumber=29662
|
|
Assignee | |
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06c7e15580ee When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
||
Comment 7•3 years ago
|
||
Do we want to uplift this to the 88 release candidate?
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 8•3 years ago
|
||
Comment on attachment 9214162 [details]
Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=mstange,spohl
Beta/Release Uplift Approval Request
- User impact if declined: Scrollbars on YouTube look bad on Windows (missing arrow buttons)
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: visit https://youtube.com, see the missing scrollbar buttons.
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively simple change to use the thumb color if the scrollbar track is transparent.
- String changes made/needed: none
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Comment 9•3 years ago
|
||
Comment on attachment 9214162 [details]
Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=mstange,spohl
Fixes missing scrollbar up/down buttons on YouTube. Approved for 88.0rc1.
|
|
||
Comment 10•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
|
||
Comment 11•3 years ago
•
|
||
I've reproduced the issue on Beta 88.0b7 and verified the fix on Nightly 89.0a1 (20210411210108) and Beta 88.0 (20210409202343) which I've downloaded from treeherder.
|
|
||
Updated•3 years ago
|
Description
•