1703607 - Exempt about:*pages from new bfcache, with the exception of about:blank

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Neha Kochar [:neha]]

browser/base/content/test/tabs/browser_navigate_through_urls_origin_attributes.js is failing for Fission+BFCache with an unexpected XULFrameLoaderCreated.

Anny, can you debug this failure please?

Comment 1

[Anny Gakhokidze [:annyG]]

browser/base/content/test/tabs/browser_navigate_through_urls_origin_attributes.js fails with bfcache + fission because it expected that XULFrameLoaderCreated event would be not fired from the point when we open a new tab in a private window to when we navigate it to about:blank. However, initial about:privatebrowsing tab gets bfcached when we navigate to about:blank, and thus we have to create a new frame loader for the about:blank page.

To keep the memory usage down, we can exempt about:* pages (with the exception of about:blank and about:reader) from bfcache.

Comment 2

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1703607 - Exempt about:*pages from new bfcache, with the exception of about:blank, r=peterv!

This also fixes test
browser/base/content/test/tabs/browser_navigate_through_urls_origin_attributes.js
which was failing for fission + bfcacheInParent, because about:privatebrowsing
was getting bfcached, and an extra XULFrameLoaderCreated event was firing, when
we were not expecting it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dccbd5752b05
Exempt about:*pages from new bfcache, with the exception of about:blank, r=peterv

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dccbd5752b05