Firefox Profiler toolbar button's menu has unreadable dark text on dark background with browser.proton.contextmenus.enabled and Dark theme enabled
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
Tracking
(firefox-esr78 unaffected, firefox87 disabled, firefox88 disabled, firefox89 verified)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | disabled |
firefox88 | --- | disabled |
firefox89 | --- | verified |
People
(Reporter: cpeterson, Assigned: itiel_yn8)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-context-menus] [priority:2a])
Attachments
(2 files)
Steps to reproduce
- Set
browser.proton.contextmenus.enabled
pref = true. - In about:addons, change the Firefox theme to "Dark" ("A theme with a dark color scheme.").
- Load https://profiler.firefox.com/
- Click the "Enable Profiler Menu Button" button.
- Click the profiler toolbar button's down arrow to expand the profiler menu.
- Expand the profiler menu's "Settings" drop-down list.
Expected result
The list of profiler settings should be readable.
Actual result
The list is unreadable because the setting names are dark text on a dark background color. See the attached screenshot.
I bisected this regression to this pushlog for bug 1682522:
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 1•3 years ago
|
||
The CSS rule that gets in the way is https://searchfox.org/mozilla-central/rev/21110f35dbb95d3c41c8c5bd363ec689900af30f/browser/themes/shared/customizableui/panelUI.inc.css#2699
And https://searchfox.org/mozilla-central/rev/21110f35dbb95d3c41c8c5bd363ec689900af30f/browser/themes/shared/customizableui/panelUI.inc.css#2688-2694 is the cause of the ugly white areas at the top/bottom of the list.
Updated•3 years ago
|
Comment 2•3 years ago
|
||
:nchevobbe: To repro on windows, macos looks fine.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 5•3 years ago
|
||
We also have some dark-mode specific styling already: https://searchfox.org/mozilla-central/rev/21110f35dbb95d3c41c8c5bd363ec689900af30f/browser/themes/shared/customizableui/panelUI.inc.css#2673-2678
We can also decide to remove all specific styling that we added at the time. The goal was to make the select box more subtle, without borders, but this makes it necessary to maintain all this specific code.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c98246c66c5 Fix the Profiler popup menulist styles for Proton r=mconley
![]() |
||
Comment 7•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 8•3 years ago
|
||
Reproduced the initial issue on Profiler using old Nightly from 2021-04-07, verified that this is fixed in latest Nightly 89.0a1.
Updated•2 years ago
|
Description
•