1703625 - Firefox Profiler toolbar button's menu has unreadable dark text on dark background with browser.proton.contextmenus.enabled and Dark theme enabled

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: Profiler_menu_screenshot.jpg

Steps to reproduce

1. Set browser.proton.contextmenus.enabled pref = true.
2. In about:addons, change the Firefox theme to "Dark" ("A theme with a dark color scheme.").
3. Load https://profiler.firefox.com/
4. Click the "Enable Profiler Menu Button" button.
5. Click the profiler toolbar button's down arrow to expand the profiler menu.
6. Expand the profiler menu's "Settings" drop-down list.

Expected result

The list of profiler settings should be readable.

Actual result

The list is unreadable because the setting names are dark text on a dark background color. See the attached screenshot.

I bisected this regression to this pushlog for bug 1682522:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bf6cf886b9683288fa453a66f999875b6ff6d3eb&tochange=a1f8152b4981d05ae1f5edaa5cb2035e20d38564

Comment 1

[Florian Quèze [:florian]]

The CSS rule that gets in the way is https://searchfox.org/mozilla-central/rev/21110f35dbb95d3c41c8c5bd363ec689900af30f/browser/themes/shared/customizableui/panelUI.inc.css#2699

And https://searchfox.org/mozilla-central/rev/21110f35dbb95d3c41c8c5bd363ec689900af30f/browser/themes/shared/customizableui/panelUI.inc.css#2688-2694 is the cause of the ugly white areas at the top/bottom of the list.

Comment 2

[Julian Descottes [:jdescottes]]

:nchevobbe: To repro on windows, macos looks fine.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

I can confirm on windows

Comment 4

[Itiel]

Attachment: Bug 1703625 - Fix the Profiler popup menulist styles for Proton r?mconley,jdescottes

Comment 5

[Julien Wajsberg [:julienw]]

We also have some dark-mode specific styling already: https://searchfox.org/mozilla-central/rev/21110f35dbb95d3c41c8c5bd363ec689900af30f/browser/themes/shared/customizableui/panelUI.inc.css#2673-2678

We can also decide to remove all specific styling that we added at the time. The goal was to make the select box more subtle, without borders, but this makes it necessary to maintain all this specific code.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c98246c66c5
Fix the Profiler popup menulist styles for Proton r=mconley

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2c98246c66c5

Comment 8

[Bogdan Maris, Desktop QA]

Reproduced the initial issue on Profiler using old Nightly from 2021-04-07, verified that this is fixed in latest Nightly 89.0a1.