1703716 - Enable Proton panels and context menus on Nightly by default

Status: RESOLVED FIXED

(Firefox :: Theme, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

As it says on the tin.

Try build cooking here: https://treeherder.mozilla.org/jobs?repo=try&revision=4f7e71c6fd887f753f8831fa7466eeb455ce37b9&selectedTaskRun=cZnUSvbsTaaX5FF3mhSdTQ.0

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1703716 - Enable Proton panels. r?jaws!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Try build cooking here with latest test fixes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92f450212ec3621e638f3bf1deb5721dd25689e1

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44916257e305
Enable Proton context menu and panels. r=jaws

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56f2b977a1dc
Backed out changeset 44916257e305 for causing accessible failures in test_visibility.xhtml
https://hg.mozilla.org/integration/autoland/rev/50d1c5990b0e
Backed out changeset 44916257e305 for causing reftest failures in menulist-shrinkwrap-2.xhtml

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfc4564739af
Revert backout of 44916257e305 since it was backed out twice.

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset 44916257e305 (Bug 1703716) for causing accessible failures in test_visibility.xhtml
Backout link: https://hg.mozilla.org/integration/autoland/rev/56f2b977a1dcb56151b72dba9dc2394b16c3b072
Accessible failures, reftest failures.
Failure logs: accessible, reftest.

I mistakenly backed 44916257e305 twice, resulting in this incorrect backout: https://hg.mozilla.org/integration/autoland/rev/50d1c5990b0e5df6065176ebf9d1b07d4465c014
I reverted that one in https://hg.mozilla.org/integration/autoland/rev/bfc4564739af31f55d7c7370af45551b35722e0c
Sorry for the clutter!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

The accessible/tests/mochitest/states/test_visibility.xhtml test failure is caused by the contextmenu change. Waiting to see which one (or if both) affected the reftest. I'm unfortunately unable to reproduce the reftest failure on Windows so far.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Looks like the failures are coming from the contextmenu pref. I'm going to land the panels pref now, and look at the contextmenu failures tomorrow.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c51fbbf20ccc
Enable Proton panels. r=jaws

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bfc4564739af
https://hg.mozilla.org/mozilla-central/rev/c51fbbf20ccc

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1703716 - Enable Proton context menus by default. r?jaws!

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Bug 1704163 needs to land before this can land.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21c7387d8d86
Enable Proton context menus by default. r=jaws

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/21c7387d8d86