1703786 - Remove nsIHttpChannelInternal.hasNonEmptySandboxingFlag and use nsILoadInfo.sandboxFlags

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

We added hasNonEmptySandboxingFlag before nsILoadInfo.sandboxFlags existed.
We can remove it from nsIHttpChannelInternal and use the flags from the load info here

Comment 1

[Hubert Boma Manilla (:bomsy)]

Hi Valentin,
Just to clarify should all other occurrences / usages of hasNonEmptySandboxingFlag be removed and replaced as well?

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Yes. It is no longer necessary to be stored or passed around via IPC as we already have it on the loadInfo.
Pretty much every instance of the string should be removed, except here where we should say:

  if (resultPolicy != nsILoadInfo::OPENER_POLICY_UNSAFE_NONE &&
      mLoadInfo->GetSandboxFlags()) {

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1703786 - Use nsILoadInfo.sandboxFlags instead r=valentin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3747f3999718
Use nsILoadInfo.sandboxFlags instead r=valentin,necko-reviewers

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3747f3999718