1703866 - <select> popups on Bugzilla have square corners

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Markus Stange [:mstange]]

After bug 1702847, <select> popups on Bugzilla with the default Light Bugzilla theme now have square corners.
This seems to be because these <select> elements have color: rgb(40, 41, 42) set on them. Setting color: black makes the popups look mostly-native again.

Can we find a different solution for this? For example, could we stop inheriting color into the <option>s? Or is there web content out there which sets color on the <select> and only background-color on the <option>?
Alternatively, could we pick a "light native" or "dark native" background appearance based on the brightness of the text color?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

On Mac other browsers disable non-native styling, fwiw, so that might be a sensible solution (just it might just be a matter of pref-flipping the dom.forms.select.customstyling pref).

Alternatively, how hard it is to support arbitrary background colors in the "native-like" popups? That's what Windows does.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1702847

Comment 3

[Markus Stange [:mstange]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

On Mac other browsers disable non-native styling, fwiw, so that might be a sensible solution (just it might just be a matter of pref-flipping the dom.forms.select.customstyling pref).

I would be very happy to do that, but don't think I have the authority to make that decision. It seems like something we should revisit after 89.

Alternatively, how hard it is to support arbitrary background colors in the "native-like" popups? That's what Windows does.

Well, the "native-like" look is only about the background and the rounded corners, and a bit of padding at the top and the bottom so that the rounded corners aren't clipped. We can easily apply the padding and rounded corners to arbitrary background colors.

Comment 4

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Stephen, is there anything planned for 89 with this bug? Thanks

Comment 5

[Stephen A Pohl]

(In reply to Pascal Chevrel:pascalc from comment #4)

Stephen, is there anything planned for 89 with this bug? Thanks

Markus might be better positioned to answer this question.

Comment 6

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

P2/S3 and no assignee, we are out of betas so this is a wontfix for 89.

Comment 7

[:Gijs (back August 25; he/him)]

(In reply to Markus Stange [:mstange] from comment #3)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

On Mac other browsers disable non-native styling, fwiw, so that might be a sensible solution (just it might just be a matter of pref-flipping the dom.forms.select.customstyling pref).

I would be very happy to do that, but don't think I have the authority to make that decision. It seems like something we should revisit after 89.

Who does have the authority for this, now that we're well past 89 - Emilio, do you know? :-)

Comment 8

[Emilio Cobos Álvarez [:emilio]]

It seems you, me, and Markus are in agreement on doing this. Stephen is the owner of the Cocoa module, so if he's fine with it too, that seems enough consensus to me between the front-end and core :)

Maybe worth at least pinging UX as a heads-up?

Comment 9

[Stephen A Pohl]

I'm on board with this too.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1703866 - Disable custom select styling on macOS. r=spohl!,Gijs!

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1703866 - Use a lazy pref getter in SelectParent.jsm. r=mconley,Gijs

Otherwise the pref set in
browser/base/content/test/forms/browser_selectpopup_colors.js doesn't
always work.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be91ae588a25
Use a lazy pref getter in SelectParent.jsm. r=mconley

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2662564f566c
Disable custom select styling on macOS. r=spohl,Gijs

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/be91ae588a25
https://hg.mozilla.org/mozilla-central/rev/2662564f566c