1703898 - Proton: External theme differences in search bar in toolbar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Pablo]

Attachment: lake.jpg

Affected versions

Nightly 89.0a1

tested on platforms

Win 7 64-bit, Ubuntu 20. windows 10 64bit

Preconditions
user.js with
user_pref("browser.proton.enabled", true);
user_pref("browser.proton.toolbar.enabled", true);
user_pref("browser.proton.urlbar.enabled", true);

themes to use
https://addons.mozilla.org/es/firefox/addon/northern-lake-by-madonna/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search

https://addons.mozilla.org/es/firefox/addon/purple-pastel-cloud-aesthetic/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search

Steps to reproduce

1. launch firefox
2. check and install both themes
3. enable search bar in toolbar ( in settings > search)
4. type something in search bar in toolbar

Expected result
theme background should match release

Actual result
background color is different
in northern lake its almost all black
in pastel theme, its showing white

Comment 1

[Pablo]

Hi romain, could you please set a priority for this here?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the search bar should follow the urlbar panel colors more or less. that text seems problematic though

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The second theme is correct imo, it follows perfectly the urlbar panel colors.

The problem here is the first theme being unreadable.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1703898 - Fix search bar panel text color with themes. r=harry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6799ad273be4
Fix search bar panel text color with themes. r=desktop-theme-reviewers,dao

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6799ad273be4

Comment 7

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.15 using firefox nightly 89.0a1