Icon is wrongly displayed on FxA notifications when add-on update banners appear in the Hamburger Menu.
Categories
(Firefox :: Menus, defect)
Tracking
()
People
(Reporter: clara.guerrero, Assigned: molly)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-hamburger-menu])
Attachments
(5 files)
Affected platforms:
Platforms: Ubuntu 20.04
Preconditions:
Reach about:config and set browser.proton.enabled = true
Create 2 fresh profiles
Step to reproduce:
- Firefox is opened.
- The add-on update banners must be displayed in the Hamburger Menu
To trigger the banners follow these steps:
(An add-on requires new permissions banner)
- Install version 1.35.2 of Bitwarden – Free Password manager - https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager/versions/?utm_content=search&utm_medium=referral&utm_source=addons.mozilla.org
install version 7.0.0 of New Tab Override - https://addons.mozilla.org/en-US/firefox/addon/new-tab-override/versions/?utm_content=recommended_fallback&utm_medium=referral&utm_source=addons.mozilla.org - Wait for the add-on to automatically attempt to update itself. The waiting process can be shortened by changing the value of the extensions.update.interval pref from 86400 to any lower value, for example 60. After changing the value, restart the browser.
- Notice that the Hamburger Menu icon displays an orange warning sign.
- Open the Hamburger Menu and observe the banner stating that the add-on requires new permissions.
- Go to about:addons > themes and switch between the different themes, and compare with dark theme
Expected result:
Icons color should match in every badge, both notifications and the hamburguer menu itself, within every theme chosen.
Actual result:
Icon is wrongly displayed in dark theme. (one looks yellow, the other one orange, seems subtle on my screenshot but it's more notorious on my screen)
Reporter | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
I was able to reproduce it on macOs 11 Big Sur.
Also, this behavior happens when the "Update available - Restart now" notification is displayed. I'll add a file.
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Bug 1702067 changed the background and icon colors for the app menu banner
notifications to fit the Proton specs, but did not update the app menu button
badges (or the accounts toolbar button badge) to match those colors, so they
currently look mismatched visually. This patch updates the badge colors to use
the same variables as the banners.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 6•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Reporter | ||
Comment 7•4 years ago
|
||
This issue is no longer reproducible in 89.0a1 (2021-04-18) (64-bit) nightly build.
Updating flags accordingly.
Best,
Clara
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 8•4 years ago
|
||
Description
•