1703945 - Display sign in link on Proton onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Emily McMinn :emcminn]

The new Proton onboarding should display the "Sign In" link in the top right of the page, just like the old onboarding layout.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1703945 - Display Sign In link on Proton onboarding

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot of SignIn link with lighter background

@rcasey for UI review of SignIn link on a lighter background image used in attached patch, thanks

Comment 3

[Ryan Casey]

Attachment: placeholder-hero-image.jpg

here is a revised placeholder image with the gradient baked in to accommodate for text link legibility

Comment 4

[Punam Dahiya [:pdahiya]]

@ryan image in JPEG format will be too big ( 1.4MB in attached image) and won't work, can we have image shared in avif format in smallest possible size, last background image in avif was 50kb, if we can have something smaller that will be even better, thanks

Comment 5

[Ryan Casey]

Attachment: placeholder-hero-image.avif

sorry! I forgot to optimize. Please try the attached.

Comment 6

[Emily McMinn :emcminn]

Got it, thank you!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26693da51e1c
Display Sign In link on Proton onboarding r=pdahiya

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/26693da51e1c

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Sign in" hyperlink is displayed in the top-right part of the new users Onboarding page.

Verified using the latest Firefox Nightly (89.0a1 Build ID - 20210416093642) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.