Extend network perfstats to include all http channel completion times (i.e. cache and network)
Categories
(Core :: Performance, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: acreskey, Assigned: acreskey)
Details
Attachments
(1 file)
In Bug 1696945 we added PerfStats collection for http channel completion time: HttpChannelCompletion_Network and HttpChannelCompletion_Cache.
These can be collected after a browsing session, as in this performance test Bug 1701927.
I've found that it would be useful to also collect aggregate http channel completion time (i.e. time to complete channels, regardless of whether the resource came from cache or network).
The reason is that if I delay the cache, then the requests will be more likely to arrive by network (due to RCWN).
But since fewer requests are now completing via cache, cache regressions actually show up as improvements!
As in this experiment where a 1ms sleep is added to cache reads.
The incoming patch adds a third network perfstat, HttpChannelCompletion, which is just the completion time for any request. Recorded in HttpChannelChild::OnStopRequest
|
Assignee | |
Comment 1•3 years ago
|
||
Add HttpChannelCompletion, which is just the completion time for any request.
This allows us to measure overall improvements, instead of shifting requests from cache to network via RCWN.
Pushed by acreskey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dcdfb2aa416f Extend network perfstats to include all http channel completion times r=necko-reviewers,valentin
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•