Closed Bug 1703979 Opened 3 years ago Closed 3 years ago

Consider cleaning ConfirmationHint

Categories

(Firefox :: Theme, task, P3)

task
Points:
3

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: bugzilla, Assigned: bigiri)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

The ConfirmationHint class powers the popup notifications under the Urlbar that confirm an action has occured. For example, "Search engine added!" appears when a search engine is added. However, all these actions were removed (afaik) in Proton. We should audit if these confirmation hints are used anywhere else. If not, we should remove the related code.

I wonder if we should move these confirmations elsewhere, maybe to the app menu button, if it's closed?

I must note I saw a Proton patch using ConfirmationHint, for Send Tab to Device, and anchoring it to the menu so it may not be unused and we may not want to remove it. Maybe it could be cleaned up, or moved elsewhere.

Summary: Consider removing ConfirmationHint → Consider cleaning ConfirmationHint

That was bug 1701544

Priority: -- → P3
Whiteboard: [proton-cleanups]
Assignee: nobody → bigiri
Status: NEW → ASSIGNED

What is the end goal for this ticket? Should I just document all the places where ConfirmationHint is used and the affected code?

Flags: needinfo?(mak)
Flags: needinfo?(htwyford)

It's... complicate. Proton removed a lot of confirmations, like "Search engine added!", that were notifying users the end of an action. Often that happened for lack of time or design. Those actions still exist but they are no more in the urlbar meatball menu, because that menu has been removed. I don't know if we still want those confirmations after Proton and where they should appear.
The first thing would probably be to document where it is still used. The second thing try to find which hints were removed in proton. Then we need Product/UX to tell us if we want to reintroduce them, using a different anchor for ConfirmationHint, since it used to anchor to the urlbar dots button that was removed. That'd be a great-or-dead kind of call.

Flags: needinfo?(mak)

What Marco said. Also, we're using ConfirmationHint in MR2, although it's not clear if those will be in the final product.

Flags: needinfo?(htwyford)

(In reply to :Gijs (he/him) from comment #8)

Actually, I misread. Let's try again...

(In reply to Bernard Igiri from comment #7)

Here are my results: https://docs.google.com/document/d/1JtbqEycv_dPnPyjupE0oKgk89a-ak75NMA-FNv7wWXY/edit?usp=sharing

(In reply to Marco Bonardo [:mak] (away 09-22 Aug) from comment #5)

It's... complicate. Proton removed a lot of confirmations, like "Search engine added!", that were notifying users the end of an action. Often that happened for lack of time or design. Those actions still exist but they are no more in the urlbar meatball menu, because that menu has been removed. I don't know if we still want those confirmations after Proton and where they should appear.

The doc highlights only the removal from page actions in https://phabricator.services.mozilla.com/D116009 , which only shows 2 callsites - the "copy url" page action and the install search engine action.

The former has completely gone away, and the latter still exists. So I guess:

The first thing would probably be to document where it is still used. The second thing try to find which hints were removed in proton. Then we need Product/UX to tell us if we want to reintroduce them, using a different anchor for ConfirmationHint, since it used to anchor to the urlbar dots button that was removed. That'd be a great-or-dead kind of call.

This is just about whether we still want the confirmationhint after adding a search engine? Harry, can you check this with the Search UX/product folks?

Flags: needinfo?(bigiri) → needinfo?(htwyford)

Search PM confirms there are no plans to bring back the "Search engine added!" hint, so we're good to remove that. Rachel Tublitz asks that we confirm with the Add-ons team that they would suffer no unintended consequences from removing this code.

Flags: needinfo?(htwyford)

(In reply to Harry Twyford [:harry] from comment #10)

Search PM confirms there are no plans to bring back the "Search engine added!" hint, so we're good to remove that. Rachel Tublitz asks that we confirm with the Add-ons team that they would suffer no unintended consequences from removing this code.

The "Search engine added!" hint was only used for OpenSearch engines. It was not used for add-ons, since they are installed via the add-on manager.

Removing unused and unwanted Confirmation Hints.

Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76dbe48227df
Removing unused/unwanted Confirmation Hints r=mak
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: