1704046 - "Not now" "Dismiss" and "Cancel" buttons from the Notification panels dissapear on Hover with High Contrast enabled

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: HighContrastHoudini.png

[Affected platforms]:
Platforms: Windows 10

[Preconditions]:

Reach about:config and set browser.proton.enabled = true
Enable High Contrast Black Windows theme

[Steps to reproduce]:

1. Launch the Firefox Browser and wait for the Update and Restart notification panel
2. Hover over the Not now/Dismiss/Cancel buttons from any notification panel

Expected Result:
The Cancel buttons should highlight correctly with High Contrast on

Actual Results:
The Cancel/Dismiss/Not now buttons dissapear from the panel when the user hovers over them with High Contrast Blac theme enabled

Please note that the same issue occurs with High Contrast White theme.

Comment 1

[Rares Doghi, Desktop QA]

Attachment: HIghCOntrast_Light_MAgic.png

Comment 2

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1704046 - Prevent popup buttons from disappearing in some Windows high-contrast themes. r=#desktop-theme-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07ab61621784
Prevent popup buttons from disappearing in some Windows high-contrast themes. r=desktop-theme-reviewers,harry

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/07ab61621784

Comment 5

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 89.0a1 (2021-04-19).

Comment 6

[Rares Doghi, Desktop QA]

Updating the status flag for this issue.

Comment 7

[Mark Striemer [:mstriemer]]

Rares, I think this might have regressed. Do you mind verifying it again for 89/beta? I suspect bug 1708690 might be the regressor which looks like it appeared in beta 8.

Comment 8

[Rares Doghi, Desktop QA]

Hi Mark, I have retested this issue for all 4 panels from Menu Notifications and they all look great no issues with them, I tested this issue in Beta 89.0b10 and Beta 89.0b11.

The only issue I noticed in beta is that on Hover the text from the Cancel button dissapears but not the entire button. I will add a screenshot, I think this issue is fixed in a different bug, I'm not sure though since theres a few issues logged on High contrast and I lost track with what gets fixed where, but if you want I can add a new one.

Comment 9

[Rares Doghi, Desktop QA]

Attachment: HighContrastText.png