1704078 - [Proton] When ETP is diasbled there is a striped background

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Oana Botisan, Desktop QA]

Attachment: etp no trackers.png

Affected versions

• Firefox 89.0a1

Affected platforms

• Windows 10 x64
• Ubuntu 18.04 x64
• macOS 10.15

Precondition
The following prefs are set to true in about:config:

• browser.proton.enabled
• browser.proton.doorhangers.enabled (for preliminary testing this also required, until the work is moved to the main pref)

Steps to reproduce

1. Go to https://www.reddit.com/
2. Click on the shield icon and turn off ETP.
3. Click on the shiled icon again and observe panel.

Expected result

• There is a one colored background.

Actual result

• There is a striped background.

Regression range

• This is not a regression.

Additional notes

• Please look at the attached image. It's the one from the specs.

Comment 1

[Oana Botisan, Desktop QA]

Attachment: etp striped background.png

This is how it looks at the moment.

Comment 3

[Sarah Ukoha]

Attachment: Bug 1704078 - Remove striped background [Proton] When ETP is disabled r=prathiksha

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/765ce198ebee
Remove striped background [Proton] When ETP is disabled r=prathiksha

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/765ce198ebee

Comment 6

[Oana Botisan, Desktop QA]

Verified the fix using Nightly 90.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. The issue is not reproducing anymore.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9216568 [details]
Bug 1704078 - Remove striped background [Proton] When ETP is disabled r=prathiksha

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very contained, well-understood CSS change.
• String changes made/needed: None.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9216568 [details]
Bug 1704078 - Remove striped background [Proton] When ETP is disabled r=prathiksha

Approved for 89 Beta 3, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/382c8455bb7d

Comment 10

[Oana Botisan, Desktop QA]

Verified the fix using Firefox 89.0b3 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing.