1704086 - Proton Tab Strip has wrong background color when browser.tabs.drawInTitlebar is false

Status: RESOLVED DUPLICATE of bug 1832732

(Firefox :: Theme, defect, P3)

Description

[Mathieu Pillard [:mat]]

Attachment: tabstrip.png

STR:

• Use default theme
• From Customize Toolbar menu, check "Title Bar" to keep the regular Operating System title bar (that sets browser.tabs.drawInTitlebar to false)
• Open a few tabs

Expected Results:

• Tab strip is has a different color than the active tab, making the active tab easy to distinguish

Actual results:

• Tab strip is the same color as the active tab (it's hard to distinguish between the active tab and the inactive ones)

Note: Not reproducible when "Title Bar" is unchecked - in that case the tab strip background is darker than the active tab as expected.

Comment 1

[Mathieu Pillard [:mat]]

Attachment: tabstrip-ok.png

For comparison : what it looks like when the Title Bar pref is flipped back to the default value. The tab strip background is different and we can distinguish the active tab from the others much more easily.

Comment 2

[Mathieu Pillard [:mat]]

For the record, this is with Ubuntu Linux 20.04 LTS (Adwaita GTK theme) and the Firefox "Default" theme, which follows operating system color scheme.

Comment 3

[Calixte Denizet (:calixte)]

I've the same problem using XFCE with the default theme: there isn't enough contrast to easily distinguish to focused tab.

Comment 4

[Harald van Dijk]

In Firefox 115.0b4, I am seeing a very different wrong background colour. I am not sure if this counts as the same bug, or a different bug. If I should report this as a new bug please let me know.

I upgraded to Firefox 115.0b4 from Firefox 113.0b9 (skipping 114 because of unrelated issues). In GTK applications, my title bar colour is yellow, my menu bars, tabs, etc. are various shades of grey. In Firefox 113.0b9, with browser.tabs.inTitlebar=0, my Firefox title bar colour is yellow, my menu bar, tabs, etc. are grey. This was as it should be. In Firefox 115.0b4, with the same configuration, my Firefox title bar colour is still yellow, but my menu bar and tab bar background is now also yellow. This is all using the System theme.

Workaround: find a non-System theme that looks close enough. I have switched to the Light theme for now.

Comment 5

[:Gijs (he/him)]

(In reply to Harald van Dijk from comment #4)

In Firefox 115.0b4, I am seeing a very different wrong background colour. I am not sure if this counts as the same bug, or a different bug. If I should report this as a new bug please let me know.

I upgraded to Firefox 115.0b4 from Firefox 113.0b9 (skipping 114 because of unrelated issues). In GTK applications, my title bar colour is yellow, my menu bars, tabs, etc. are various shades of grey. In Firefox 113.0b9, with browser.tabs.inTitlebar=0, my Firefox title bar colour is yellow, my menu bar, tabs, etc. are grey. This was as it should be. In Firefox 115.0b4, with the same configuration, my Firefox title bar colour is still yellow, but my menu bar and tab bar background is now also yellow. This is all using the System theme.

Workaround: find a non-System theme that looks close enough. I have switched to the Light theme for now.

This seems like a separate issue. Emilio, are you aware of anything that's changed in 115 that would explain this?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah, I think it's most likely from bug 1832732. Can you file a separate bug and needinfo me, letting me know what GTK theme are you using?

We now use the titlebar color to render the tab backgrounds unconditionally. That generally provides better results, specially with defaults (no menubar). I can try to look and see if there's an easy way to provide a better default in those themes tho.

Comment 7

[Harald van Dijk]

Thank you, reported as bug 1838460.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

This was fixed by bug 1832732 (using titlebar colors on Adwaita looks fine).