1704087 - Proton: Some brighttext themes have ugly border color for the search bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Pablo]

Attachment: toolbarborder.jpg

Affected versions

Nightly 89.0a1

Windows10 Dark theme: Affected
Windows10 Light theme: Affected
Ubuntu Dark theme: not affected
Ubuntu Light theme: Affected because tere is no border seen
MacOS: Not affected

tested on platforms

Ubuntu 20. windows 10 64bit, MacOS 10.14

Preconditions
user.js with
user_pref("browser.proton.enabled", true);
user_pref("browser.proton.toolbar.enabled", true);
user_pref("browser.proton.urlbar.enabled", true);

themes to use
-stock light theme
-stock dark theme

Steps to reproduce

-launch firefox
-change theme to dark theme
-enable search bar in toolbar ( in settings > search)
-Open a new tab
-type something in searchbar

Expected result
the borders should look nicer

Actual result
there are white areas in the border (for dark theme)

Comment 1

[Pablo]

Hi romain, could you please set a priority for this here?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I cannot reproduce this on Windows 10, I wonder if it was an effect of not enabling the browser.proton.doorhangers.enabled pref

Pablo, could you please check if this is still valid in nightly, and if so does it require additional steps?

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: sshot

This is what I see on Windows 10

Comment 4

[Pablo]

Hi marco, today it looks way better than what it was before. I just tried it on windows10 and on the left border is a lot more thin.
but there is another thing i noticed, not sure if you want me to open a new bug or continue with this bug, its regarding to borders too.

1)Put dark theme or Light theme, it is more noticeable in light theme but you can try dark theme too.
2) go to about:preferences#search , (just to have a white page loaded)
3) type anything on the Search Bar
4) check the shadow on the right side, and on the bottom side of the Search Bar.

Then compare that shadow, but typing something in the URL bar , megabar

I see more shadow on the Seach Bar , in the right border, and bottom border.

Url and search bar should look equal i think,

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

We have no control over the shadow in the search bar, it is designed by the widgets code. To be able to control the search bar shadow we should replace its panel, similarly to what we made for the urlbar. Considered the search bar is not something we ship on by default, and it's a low priority for Search, we are not going to spend time on that.
In practice, we accept the urlbar and the search bar will look a bit different, and we mostly care about color consistency for Proton. Thus a bug to change the shadow would end up either as a wontfix or a long term P5.

If now the borders look ok, I think this is a WFM.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I'm reopening this because I noticed this issue on the Retro LWT theme, it may be lower priority since it only affects certain themes. It may also be something with layout/graphics because the border looks strange.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

may be related to bug 1705814

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Testing with https://addons.mozilla.org/en-US/firefox/addon/retro-console-dark-red/ it looks like bug 1704040 also fixed this.

Comment 9

[Pablo]

Hi Marco

i was about to set this to verify but, as you said if there is no control on the shadow, Then Mac and Windows will show a shadow but Ubuntu will not show a shadow, is that correct?

This causes the LIGHT THEME inside firefox to have an almost unnoticeable border on search bar using Ubuntu 20. (because there is no shadow)

I verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b7, but i had doubts regarding the light theme border in ubuntu

thanks

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Pablo from comment #9)

i was about to set this to verify but, as you said if there is no control on the shadow, Then Mac and Windows will show a shadow but Ubuntu will not show a shadow, is that correct?

Some Ubuntu will show a shadow, some not. It depends on their graphics subsystem. Bug 1708136 should solve that, but likely not for 89.

This causes the LIGHT THEME inside firefox to have an almost unnoticeable border on search bar using Ubuntu 20. (because there is no shadow)

There should be a 1px border since bug 1696500 has been fixed.
I can see that border clearly, but YMMV. We care that there is a border for 89, users that prefer a more visible border can pick a different theme for now.

Comment 11

[Pablo]

this was already verified on windows10 64bit, win10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b7