1704127 - When opening a native context menu in the bookmarks sidebar, add-on items are missing

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Steps to reproduce:

1. Enable widget.macos.native-context-menus.
2. Install the Side View add-on from https://addons.mozilla.org/en-US/firefox/addon/side-view/ .
3. Open the bookmarks sidebar.
4. Right-click a bookmark.

Expected results:
The menu should contain an "Open in sidebar" item.

Actual results:
The item is not present. It is only present if widget.macos.native-context-menus is false.

This bug was caught by the test browser/components/extensions/test/browser/browser_ext_contextMenus.js.

Comment 1

[Markus Stange [:mstange]]

The problem here is that native context menus do not set the right x/y values on the popupshowing event. onBookmarksContextMenu uses those values to find the right cell in the tree.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1704127 - Use NS_NewRunnableFunction instead of a custom nsXULPopupShowingEvent class. r=tnikkel

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1704127 - Rename FirePopupShowingEvent to BeginShowingPopup. r=tnikkel

Depends on D111499

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1704127 - Factor out part of BeginShowingPopup into a new FirePopupShowingEvent method. r=tnikkel

Depends on D111500

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1704127 - Fire the initial popupshowing event for native context menus from nsXULPopupManager, not from nsMenuX. r=tnikkel

This makes sure that all the correct properties are set, such as the event
position and input mode.

Depends on D111501

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ecb4413768
Use NS_NewRunnableFunction instead of a custom nsXULPopupShowingEvent class. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/60238814a4bd
Rename FirePopupShowingEvent to BeginShowingPopup. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/3a08030ba3a3
Factor out part of BeginShowingPopup into a new FirePopupShowingEvent method. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/b23d2354ba02
Fire the initial popupshowing event for native context menus from nsXULPopupManager, not from nsMenuX. r=tnikkel

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/68ecb4413768
https://hg.mozilla.org/mozilla-central/rev/60238814a4bd
https://hg.mozilla.org/mozilla-central/rev/3a08030ba3a3
https://hg.mozilla.org/mozilla-central/rev/b23d2354ba02

Comment 8

[Emil Ghitta, QA [:emilghitta]]

Reproduced the issue mentioned in comment 0 using Firefox 89.0a1 (build from 2021-04-09).

This issue is verified fixed using Firefox 89.0a1 (BuildId:20210414160838) on macOS 10.15 with native menus enabled.