1704128 - about:welcome needs to get default top sites from AboutNewTab.jsm rather than DefaultSites.jsm

Status: RESOLVED DUPLICATE of bug 1720763

(Firefox :: Messaging System, defect, P2)

Description

[Dão Gottwald [:dao]]

Starting with Firefox 87, default top sites are loaded from remote settings rather than DefaultSites.jsm. DefaultSites.jsm is not going to be updated anymore and is slated for removal. Like UrlbarProviderTopSites.jsm, about:welcome needs to get default sites from AboutNewTab.getTopSites() instead.

Comment 1

[Punam Dahiya [:pdahiya]]

New proton onboarding doesn't display static topsites, let's revisit this in future based off our learning from upcoming experiments

Comment 2

[Dão Gottwald [:dao]]

(In reply to Punam Dahiya [:pdahiya] from comment #1)

New proton onboarding doesn't display static topsites, let's revisit this in future based off our learning from upcoming experiments

Can we go ahead and remove AboutWelcomeChild.jsm's usage of DefaultSites.jsm?

Comment 3

[Punam Dahiya [:pdahiya]]

We are planning holdback experiments to compare proton new user onboarding with old experience that will need default topsites in Fx89. If it's a simpler change we should replace DefaultSites.jsm with AboutNewTab.getTopSites() rather than remove in AboutWelcomeChild.jsm as originally intended in this bug.

b/w there is one more place below which refers to DefaultSites.jsm and will be good to scope as we remove DefaultSites.jsm
https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ActivityStream.jsm#135

Comment 4

[Dão Gottwald [:dao]]

(In reply to Punam Dahiya [:pdahiya] from comment #3)

We are planning holdback experiments to compare proton new user onboarding with old experience that will need default topsites in Fx89. If it's a simpler change we should replace DefaultSites.jsm with AboutNewTab.getTopSites() rather than remove in AboutWelcomeChild.jsm as originally intended in this bug.

Okay.

b/w there is one more place below which refers to DefaultSites.jsm and will be good to scope as we remove DefaultSites.jsm
https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ActivityStream.jsm#135

This code isn't used anymore.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1704128 - Get default top sites from AboutNewTab.jsm rather than DefaultSites.jsm. r=pdahiya

Comment 6

[Dão Gottwald [:dao]]

pdahiya, would you be the right person to review my patch?

Comment 7

[Punam Dahiya [:pdahiya]]

(In reply to Dão Gottwald [::dao] from comment #6)

pdahiya, would you be the right person to review my patch?

@dao sorry for delay, yes I will be able to review it today, thanks!

Comment 8

[Punam Dahiya [:pdahiya]]

Marking bug to be picked as ujet-tech-debt as part of clean up pre-MR1 experience which rely on display default TopSItes

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:tspurway, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.