Closed
Bug 1704185
Opened 3 years ago
Closed 3 years ago
Figure out better name for JS::GetRealmWeakMapKey
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
90 Branch
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
bug 1702863 added JS::GetRealmWeakMapKey
, that returns a dedicate object for embedding to represent the realm.
I chose the name based on the fact that, currently it's stored into a weak map in the embedding, associating information for the realm,
but apparently the name doesn't much describe the actual purpose in the embedding side.
Comment 1•3 years ago
|
||
Maybe GetRealmKeyObject?
Assignee | ||
Comment 2•3 years ago
|
||
(In reply to Peter Van der Beken [:peterv] from comment #1)
Maybe GetRealmKeyObject?
Thanks! it sounds good :)
I'll rewrite the code and filenames.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•3 years ago
|
||
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/ff493a044fa1 Rename JS::GetRealmWeakMapKey to JS::GetRealmKeyObject. r=peterv
Comment 5•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•