1704241 - [wpt-sync] Sync PR 28430 - [SelectMenu] Add basic support for positioning <selectmenu>'s popup.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28430 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28430
Details from upstream follow.

b'Ionel Popescu <[e-mail]>' wrote:

[SelectMenu] Add basic support for positioning <selectmenu>'s popup.

The \<selectmenu>'s popup position is determined by:

• vertically: where there is more space available
• horizontally: if there is enough space (\<selectmenu>'s width for now)
  or there is more space, the popup is going to be left aligned; if not
  it is going to be right aligned;

For now, since the anchored positioning shceme is not yet provided,
the position is provided by overriding the computed style for
the applicable top/left/right/bottom properties.

Bug: 1121840
Change-Id: I7d75e62d52595b0efa5e7295ab8f8151499c5857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812432
Commit-Queue: Ionel Popescu \<[e-mail]>
Reviewed-by: Rune Lillesveen \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Reviewed-by: Dan Clark \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#871204}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 28430 applied with additional changes from upstream: 19456e4361838056db374f011b72a89ca80635ae, 4546ec6736fec34353c89f6b2c9f36f7d454e141

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2588200012a316c2504e79774e9f3a54402d799

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL : 4
TIMEOUT: 1

Chrome

OK : 1
FAIL : 4
TIMEOUT: 1

Safari

OK : 1
FAIL : 4
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-option-arbitrary-content-displayed.tentative.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/html/semantics/forms/the-selectmenu-element/selectmenu-popup-position.tentative.html
The popup should be bottom left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
The popup should be top left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
The popup should be bottom right positioned: FAIL (Chrome: FAIL, Safari: FAIL)
The popup should be top right positioned: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/321cc6a0faf8
[wpt PR 28430] - [SelectMenu] Add basic support for positioning <selectmenu>'s popup., a=testonly
https://hg.mozilla.org/integration/autoland/rev/37d950e7d9e0
[wpt PR 28430] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/321cc6a0faf8
https://hg.mozilla.org/mozilla-central/rev/37d950e7d9e0