[wpt-sync] Sync PR 28430 - [SelectMenu] Add basic support for positioning <selectmenu>'s popup.
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 28430 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/28430
Details from upstream follow.
b'Ionel Popescu <iopopesc@microsoft.com>' wrote:
[SelectMenu] Add basic support for positioning <selectmenu>'s popup.
The \<selectmenu>'s popup position is determined by:
- vertically: where there is more space available
- horizontally: if there is enough space (\<selectmenu>'s width for now)
or there is more space, the popup is going to be left aligned; if not
it is going to be right aligned;For now, since the anchored positioning shceme is not yet provided,
the position is provided by overriding the computed style for
the applicable top/left/right/bottom properties.Bug: 1121840
Change-Id: I7d75e62d52595b0efa5e7295ab8f8151499c5857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812432
Commit-Queue: Ionel Popescu \<iopopesc@microsoft.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Mason Freed \<masonf@chromium.org>
Reviewed-by: Dan Clark \<daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#871204}
Assignee | ||
Comment 1•3 years ago
|
||
PR 28430 applied with additional changes from upstream: 19456e4361838056db374f011b72a89ca80635ae, 4546ec6736fec34353c89f6b2c9f36f7d454e141
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2588200012a316c2504e79774e9f3a54402d799
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 4 subtests
Status Summary
Firefox
OK : 1
FAIL : 4
TIMEOUT: 1
Chrome
OK : 1
FAIL : 4
TIMEOUT: 1
Safari
OK : 1
FAIL : 4
TIMEOUT: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/forms/the-selectmenu-element/selectmenu-option-arbitrary-content-displayed.tentative.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/html/semantics/forms/the-selectmenu-element/selectmenu-popup-position.tentative.html
The popup should be bottom left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
The popup should be top left positioned: FAIL (Chrome: FAIL, Safari: FAIL)
The popup should be bottom right positioned: FAIL (Chrome: FAIL, Safari: FAIL)
The popup should be top right positioned: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/321cc6a0faf8 [wpt PR 28430] - [SelectMenu] Add basic support for positioning <selectmenu>'s popup., a=testonly https://hg.mozilla.org/integration/autoland/rev/37d950e7d9e0 [wpt PR 28430] - Update wpt metadata, a=testonly
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/321cc6a0faf8
https://hg.mozilla.org/mozilla-central/rev/37d950e7d9e0
Description
•