Closed Bug 1704297 Opened 3 years ago Closed 3 years ago

[nnt] Focus ring does not look correct on inputs at bochk.com

Categories

(Core :: Widget, defect)

Firefox 88
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: Fanolian+BMO, Unassigned)

References

(Regression, )

Details

(Keywords: nightly-community, regression, reproducible)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0
Build ID: 20210410091448

Steps to reproduce

  1. Set widget.non-native-theme.enabled to true.
  2. Go to https://its.bochk.com/login/ibs_lgn_index_e.jsp.
  3. Click the 3 input boxes.

Actual result

Please see the attached screenshot. (First box is highlighted by mouse click; 3rd box is set to :focus-visible for comparison.)

For the inputs for name and password, border highlight appears only at the left.

Expected result

Either the whole box is highlighted, or not highlighted at all.

Workaround

Disable widget.non-native-theme.enabled.

Regression

Last good Nightly: 2021-03-05
First bad Nightly: 2021-03-06
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=95b6c826ad974a967364cb1f137bd8a766051d0a&tochange=de11c0fbd90155ddd1fc8450b45ed99a55c3c2cf

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4197952997ba47f2b4d1968d57230a4c448ddaa3&tochange=10be9bdf55eb764854914829d389f0469f10faf2

This is regressed by bug 1696709.

I tried to make a reduced testcase. This looks like the bug I am reporting but it is instead regressed by bug 1687022.

Similar to bug 1690507 (but that's about native theme), if I zoom in all the way some sides, but not all, of border highlights re-appear.

Has Regression Range: --- → yes
Has STR: --- → yes
Regressed by: 1696709, win-nnt

Actually I think it is called focus ring...

Some OS info:
Windows 10, 1920x1080 at OS 100% scale.
Nvidia GTX760 driver 461.72
WebRender is on.

Summary: [nnt] Input border highlight does not look correct at bochk.com → [nnt] Focus ring does not look correct on inputs at bochk.com

This is invalid. Outline by default renders outside of the border area. It was a bug that we were covering the border, and it just happened by chance. Safari behaves like Firefox here.

The site could style it with outline-offset: -2px or such, or even better, they could remove overflow: hidden from #content #loginbox #loginbox-content #loginbox-content-container span.

If you use outline: 2px solid; on the input, then Chrome behaves exactly just like Firefox. But I don't think outline-style: auto should break the rules of how outlines work like Chrome does.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: