Closed Bug 1704323 Opened 3 years ago Closed 3 years ago

Proton context menu to large

Categories

(Firefox :: Menus, defect, P3)

Desktop
Windows 10
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox89 --- affected

People

(Reporter: speciesx, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-context-menus])

Attachments

(2 files)

Attached image 1080.png

The proton context menu is way to long.
On my 1080P Notebook the proton context menu is 50% longer as the old one and now it takes nearly the full display height.

Attached image 2160.png

The padding of the Proton context menus was chosen intentionally, so this inflation is expected. Still, going to throw into the proton-context-menus metabug in case we want to take a closer look at this.

Severity: -- → S4
Whiteboard: [proton-context-menus]
Priority: -- → P3
Status: UNCONFIRMED → NEW
Ever confirmed: true

Marking as "Won't Fix" since the spacing is per spec

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX

So we can't even say that the spec is wrong? Nobody is shocked that the menu is almost overflowing OUTSIDE the screen? A few more add-ons will make this happen…

(In reply to Geobert Quach from comment #4)

So we can't even say that the spec is wrong? Nobody is shocked that the menu is almost overflowing OUTSIDE the screen? A few more add-ons will make this happen…

I don't think this menu was encountered when specifying context menus, when on https://9gag.com/ the first video is also a hyperlink to https://9gag.com/gag/aK6EMDg which seems to cause both hyperlink context menu entries and video playback contextual menu entries to appear.
Mike, is that the expected behavior given that clicking the video will launch the video as opposed to following the hyperlink (unsure how this works...)

Flags: needinfo?(mconley)

From what I can tell from their highly obfuscated code, this site is wrapping the video in the an anchor, and then calling preventDefault() on the click event to prevent the link navigation. I've built a reduced testcase here:

https://jsbin.com/winojufeyo/edit?html,css,js,output

I think this is expected, in that from Firefox's perspective, context-clicking on the video is context clicking on both a link and a video. We don't have the ability to know at runtime when showing the context menu whether or not a site will prevent the navigation from occurring when doing a left-click.

Flags: needinfo?(mconley)

Can this be considered for the compact theme please?

Things like this are particularly why we had (and currently somehow have) a compact theme.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: