1704338 - misc double tap test cleanup

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1704338. Merge helper_touchscreen_doubletap_zoom.html and helper_touchpad_doubletap_zoom.html. r?botond

The new format lets us use the same test file with a different arg to test both kinds.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1704338. Factor out doubleTapOn test function. r?botond

Depends on D111552

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1704338. Use promiseApzFlushedRepaints instead of promiseOnlyApzControllerFlushed in doubleTapOn. r?botond

No reason to only wait for the controller, I think we want to wait for the full repaint. Seems to make things less intermittent, the test in bug 1702464 was already using this.

Depends on D111553

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5bedd154e09
Merge helper_touchscreen_doubletap_zoom.html and helper_touchpad_doubletap_zoom.html. r=botond
https://hg.mozilla.org/integration/autoland/rev/02fa623250a4
Factor out doubleTapOn test function. r=botond
https://hg.mozilla.org/integration/autoland/rev/5b9d86bed85f
Use promiseApzFlushedRepaints instead of promiseOnlyApzControllerFlushed in doubleTapOn. r=botond

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b15d9ec985db
Fix lint failures r=fix CLOSED TREE

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1704338. Include a couple more tests that I forgot to include in the refactor.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9fb3b62404b
Include a couple more tests that I forgot to include in the refactor.

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d5bedd154e09
https://hg.mozilla.org/mozilla-central/rev/02fa623250a4
https://hg.mozilla.org/mozilla-central/rev/5b9d86bed85f
https://hg.mozilla.org/mozilla-central/rev/b15d9ec985db
https://hg.mozilla.org/mozilla-central/rev/b9fb3b62404b