1704394 - Extract opening and closing tab related helpers from browser.js to the TabManager module

Status: NEW

(Remote Protocol :: Marionette, task, P3)

Description

[Julian Descottes [:jdescottes]]

See https://phabricator.services.mozilla.com/D109431#inline-619034:

It would be good to get these extra helper modules out of browser.js.
But maybe we should do it for the tab-manager.js module (which we already have in Remote Agent).

about:

let tabBrowser = browser.getTabBrowser(win);

See also https://phabricator.services.mozilla.com/D109431#inline-619052 which suggests to also move the getIdForBrowser created in window-manager.js to another helper.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This should only be about tab related methods. For window specific helpers we have a separate shared module.

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

This should only be about tab related methods. For window specific helpers we have a separate shared module.

Sorry, I meant browser & tab.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not fully sure if we need this for M1 but adding it to the list for now so that we can get it discussed.

Comment 4

[Julian Descottes [:jdescottes]]

As discussed in the triage meeting, should move to this tab-manager module:

• browser.js MobileTabBrowser
• browser.js getBrowserForTab
• browser.js getTabBrowser

We should also attempts to extract tab-related methods from the Context class in browser.js: openTab and closeTab:

• browser.js openTab
• browser.js closeTab

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We don't need it right away but would be good to have support for Firefox on Android for sure.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Julian Descottes [:jdescottes] from comment #4)

As discussed in the triage meeting, should move to this tab-manager module:

• browser.js MobileTabBrowser
• browser.js getBrowserForTab
• browser.js getTabBrowser

All this items have been done by bug 1747222.

We should also attempts to extract tab-related methods from the Context class in browser.js: openTab and closeTab:

• browser.js openTab
• browser.js closeTab

We cannot fully extract these given that WebDriver HTTP will need extra code (waiting for the tab to finish loading) but maybe we can have the custom code in driver.js instead. I've made some initial changes also on bug 1723919.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm doing some updates for opening and selecting a tab over on bug 1749666.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Lets see what else we can simplify once bug 1533058 has been fixed.