1704458 - Toolbox title isn't updated when navigating with server side target switching enabled

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

When enabling devtools.target-switching.server.enabled while having the toolbox shown in a window, its title isn't updating on navigation. That's because we rely on will-navigate and navigate, which don't fire in case of server side target switching.

We should instead rely on onTargetAvailable and/or DOCUMENT_EVENT, which both fires reliably.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

We should be able to do Bug 1691576 at the same time as this one

Comment 3

[Alexandre Poirot [:ochameau]]

Let's have this bug to focus on updating targetFront's title/url attributes out of DOCUMENT_EVENT.
And bug 1691576 to focus on making toolbox.js to update toolbox's title out of DOCUMENT_EVENT.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1704458 - Update target title based on DOCUMENT_EVENT's

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1704458 - [devtools] Pass isFrameSwitching in DOCUMENT_EVENT resources. r=jdescottes.

This will be consumed by the toolbox to not update detached window title when
the user triggered a frame switching (i.e. selected a document in the frame switcher
menu in the toolbar).

Depends on D104540

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1704458 - [devtools] Update targetFront url and title on DOCUMENT_EVENT resource. r=ochameau,jdescottes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7181701f11c
[devtools] Pass isFrameSwitching in DOCUMENT_EVENT resources. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/c1954aab8ab2
[devtools] Update targetFront url and title on DOCUMENT_EVENT resource. r=ochameau,jdescottes.

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_target_list_frames.js along with Bug 1691577 and Bug 1691576

backout: https://hg.mozilla.org/integration/autoland/rev/ff72ff2eabd7bb6654d1a8978c407b2a6daee14f

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=EbfwoYjNRCesryIKYjiuLA.0&revision=5f42d01c0ec3afa30835e1f284647eaaa8276489&group_state=expanded

failure log:

• TEST-UNEXPECTED-FAIL | devtools/shared/commands/target/tests/browser_target_list_frames.js | A promise chain failed to handle a rejection: Connection closed, pending request to server0.conn8.watcher2, type watchResources failed
• TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_window_title_frame_select.js | Test timed out -

Comment 9

[Natalia Csoregi [:nataliaCs]]

Also failing: TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | A promise chain failed to handle a rejection: Connection closed, pending request to server0.conn18.child4/obj23, type release failed

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

• I'll push a fix for browser_target_list_frames.js
• browser_toolbox_window_title_frame_select.js seems unrelated, i triggered a TV job on central and got the same failure: https://treeherder.mozilla.org/jobs?repo=try&revision=25a28ed9eb6d120f35e8a3e7498267c0a39a3e42
• browser_ext_devtools_panels_elements_sidebar.js looks unrelated as well (still waiting for TRY results)

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

browser_ext_devtools_panels_elements_sidebar.js failures does only show up with my patch queue, I'll investigate

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6f9892cf815b
https://hg.mozilla.org/mozilla-central/rev/8056959c9079