1704483 - Screen Readers will not read the email text in the Hamburger menu notification banner

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Rares Doghi, Desktop QA]

[Affected platforms]:
Platforms: Windows 10

[Preconditions]:

Reach about:config and set browser.proton.enabled = true
[Steps to reproduce]:

Launch the Firefox Browser and Create a new account without verifying it.
Reach the Fxa Notification from the Hamburger menu using NVDA or other screen readers.
Move the Mouse cursor on top of the email address.
Restart the Browser and reach the Fxa Notification from the Hamburger menu using NVDA and hover over the email address.

Expected Result:
NVDA should read the Email address when the user hovers over it.

Actual Results:
NVDA does not read the email adress at all.

Comment 1

[Tyler Duzan]

Asa can you review and assess severity?

Comment 2

[Asa Dotzler [:asa]]

If I understand this correctly, it's an access-S3. It's a bit less clear without the email address but users still receive enough information to know what the next step is to verify the account complete the sign-up process. Also, if a user activates that menu item it takes them to a sub-panel that does announce the address.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r?morgan,Jamie

The full text is split into 2 labels, one describing state and one containing the e-mail address.
To sighted users, both are visible. When this happens, let's use aria-labelledby to ensure both
labels are associated with the button control, so that both are read by screenreaders.

Note that in non-proton, the only label (both visible and otherwise) is the
state (the e-mail is not shown/used).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efd2fb859d37
improve a11y labeling of disconnected/errored account item in the hamburger menu, r=morgan

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/efd2fb859d37

Comment 6

[:Gijs (he/him)]

Comment on attachment 9218940 [details]
Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r?morgan,Jamie

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor JS-only changes to properties exposed to accessibility in some (relatively rarely seen) fxa states; grafts cleanly to beta
• String changes made/needed: nope

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218940 [details]
Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r?morgan,Jamie

Approved for 89 beta 6, thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8043d3125b5b

Comment 9

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Beta 89.0b6 as well as our Latest nightly build 90.0a1 (2021-04-29)