Closed Bug 1704548 Opened 3 years ago Closed 3 years ago

Start emitting Target.receivedMessageFromTarget events again

Categories

(Remote Protocol :: CDP, defect, P2)

defect

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Over on bug 1598468 we stopped sending events for Target.receivedMessageFromTarget due to lots of traffic and no usage in Puppeteer. But it looks like that there are some clients out there that actually would like to make use of it.

As such we should check if we can just undo the following changeset:
https://hg.mozilla.org/mozilla-central/rev/f859313703c9

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Blocks: 1704619
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/295f4dbf36b5
[remote] Re-enable Target.receivedMessageFromTarget events. r=remote-protocol-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #0)

Over on bug 1598468 we stopped sending events for Target.receivedMessageFromTarget due to lots of traffic and no usage in Puppeteer. But it looks like that there are some clients out there that actually would like to make use of it.

To clarify a bit more... the underlying reason why we temporarily disabled this event was because of all the events related to the non-existent favicon. Given that this is fixed now there is no problem anymore.

Summary: Reconsider start emitting Target.receivedMessageFromTarget events again → Start emitting Target.receivedMessageFromTarget events again
Blocks: 1706262
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: