1704584 - Add "password-rules" data in tree

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Tim Giles [:tgiles]]

In order to simplify development regarding the improved password generation experience, we should add Apple's password rules in tree before attempting to automate the update process for this data.

Note: The most straightforward way to complete this is by uploading the current password-rules.json to the Remote Settings development server and cURLing the data into its appropriate spot in tree.

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1704584 - Add password-rules data in tree. r=leplatrem

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1704584 - Add password-rules data in tree. r=leplatrem

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee83f690b75a
Add password-rules data in tree. r=leplatrem

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ee83f690b75a

Comment 5

[Julien Cristau [:jcristau]]

This causes build breakage at the next automated sync of password-rules.json from remote-settings:
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=JNrGSHdDRyS1JoIbS2xfXg.0&revision=3553bec79be394dce8fa4848309693df0713fc7c

Mat, can we address bug 1680493 in a generic way or do we need to add this one more file to the allowlist?

Comment 6

[Mathieu Leplatre [:leplatrem]]

For now, you can add the file here https://searchfox.org/mozilla-central/rev/2c991232499e826e46f9d976eb653817340ba389/browser/installer/allowed-dupes.mn#62-66

Mat, can we address bug 1680493 in a generic way or do we need to add this one more file to the allowlist?

Unless you have another simple solution in mind, updating the documentation may be enough.

The collection is likely to be empty at the early stages, but very rarely afterwards.
In some specific cases, if developers know in advance that there is a chance for the collection to be emptied in the future, then they could just add it to allowed-dupes.mn.

If you have ideas for bug 1680493, let's talk there :)

Comment 7

[Julien Cristau [:jcristau]]

Attachment: Bug 1704584 - allow password-rules.json as a duplicate file. r?leplatrem

Comment 8

[Tim Giles [:tgiles]]

Attachment: Bug 1704584 - Fix build breakage from empty password rules Remote Settings collection. r=leplatrem,jcristau

Comment 9

[Tim Giles [:tgiles]]

Hmm, didn't know that an empty collection would cause a build breakage...will keep that in mind next time I'm working with a collection. After the initial sync of data, tracked by this JIRA ticket which will set up an update job for the data, this collection should never be empty again. Let me know if you need any other information from me.

Comment 10

[Julien Cristau [:jcristau]]

Thanks Tim. Sounds like we'll be able to remove the file from the allowlist when the first rules are added :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6794a4f2d926
allow password-rules.json as a duplicate file. r=leplatrem

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6794a4f2d926

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97a11bfda3c9
allow password-rules.json as a duplicate file - Thunderbird part. rs=bustage-fix DONTBUILD