Closed Bug 1704678 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28451 - webcodecs: Implementation of AudioEncoder.isConfigSupported()

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox89 fixed)

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28451 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28451
Details from upstream follow.

b'Eugene Zemtsov <eugene@chromium.org>' wrote:

webcodecs: Implementation of AudioEncoder.isConfigSupported()

Bug: 1176442, 1197760
Change-Id: I7045c8413a0267422b45861003e01d3e5ef7cc9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2816223
Commit-Queue: Eugene Zemtsov \<eugene@chromium.org>
Reviewed-by: Thomas Guilbert \<tguilbert@chromium.org>
Reviewed-by: Chrome Cunningham \<chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#871727}

PR 28451 applied with additional changes from upstream: 9097d3f783ba87b8928fd3516fa475473e21bc1a, f37d80e1d7cbb0d9cef974a59c384f70c9afb28e, 5639630188f30b5a6ff67a3cfc7e0e4a95e65817, c25923e1e3a5c2de964768aded0243c2ed153365

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 15 subtests

Status Summary

Firefox

OK : 2
FAIL : 25
ERROR: 1

Chrome

OK : 2
PASS : 1
FAIL : 38
ERROR: 1

Safari

OK : 2
FAIL : 25
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/audio-encoder-config.any.worker.html
Test that AudioEncoder.isConfigSupported() rejects invalid config:Emtpy codec: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Unrecognized codec: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too small: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too large: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Too few channels: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Way too many channels: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Bit rate too big: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() doesn't support config:Too many channels: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() doesn't support config:Bitrate is too low: FAIL (Chrome: FAIL, Safari: FAIL)
AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":8000,"numberOfChannels":1}: FAIL (Chrome: FAIL, Safari: FAIL)
AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2}: FAIL (Chrome: FAIL, Safari: FAIL)
AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"bitrate":128000,"bogus":123}: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/audio-encoder-config.any.html
Test that AudioEncoder.isConfigSupported() rejects invalid config:Emtpy codec: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Unrecognized codec: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too small: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Sample rate is too large: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Too few channels: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Way too many channels: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() rejects invalid config:Bit rate too big: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() doesn't support config:Too many channels: FAIL (Chrome: FAIL, Safari: FAIL)
Test that AudioEncoder.isConfigSupported() doesn't support config:Bitrate is too low: FAIL (Chrome: FAIL, Safari: FAIL)
AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":8000,"numberOfChannels":1}: FAIL (Chrome: FAIL, Safari: FAIL)
AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2}: FAIL (Chrome: FAIL, Safari: FAIL)
AudioEncoder.isConfigSupported() supports:{"codec":"opus","sampleRate":48000,"numberOfChannels":2,"bitrate":128000,"bogus":123}: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/audio-encoder.any.html: ERROR (Chrome: ERROR, Safari: ERROR)
Simple audio encoding: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d0a3a524fbe
[wpt PR 28451] - webcodecs: Implementation of AudioEncoder.isConfigSupported(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/3e41fa173604
[wpt PR 28451] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0d0a3a524fbe
https://hg.mozilla.org/mozilla-central/rev/3e41fa173604

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.