Closed Bug 1704860 Opened 4 years ago Closed 4 years ago

gitlab drag comment not working

Categories

(Core :: DOM: Events, defect)

Firefox 87
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox87 --- affected
firefox88 --- affected
firefox89 --- affected

People

(Reporter: u683564, Unassigned)

Details

Attachments

(1 file)

Attached video record

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

tried to drag the comment pointer on gitlab

Actual results:

nothing

Expected results:

the pointer is must be dragged with my mouse pointer

Thanks for reporting this. Unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the situation or problem, please read https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines and add a more useful description to this report, including clear and complete steps to reproduce (step by step) as a list which leaves no room for interpretation.

Flags: needinfo?(shur1kinsta)

Hey. I meant when you are using gitlab and you are managing mergre request, you have option of code review and adding comments about a code changes of commits of a merge requst. So, in case to do multiline comment you need to drag comment icon pointer with pressing LMB and moving it from first to last wanted line, and then "drop it", unpress LMB. So, when I try to it in Firefox, I can't move the comment icon, it does not work. I have tested it in another browsers, like Microsoft Edge and Google Chrome, and it works fine. In a video I tried to show, what happens when I hold LMB and moving the pointer, so you can see that the comment icon is not moving with a mouse pointer.
Thank you.

Flags: needinfo?(shur1kinsta)

I managed to reproduce this on Firefox and also on Chome on Windows 10 x64 and on macOS 10.15.
I'm not sure about the correct behaviour you expected here.
Here is a screen recording done on chrome showing the same behaviour in Firefox: https://streamable.com/8i8isu

Could you please offer detailed steps and maybe a screen record with the expected behaviour?
Thanks.

Flags: needinfo?(shur1kinsta)

Yes, I have recorded the excepted behavior in a Microsoft Edge:
https://youtu.be/HGRBXbfv9bE
As you can see, when I move the mouse pointer, the comment pointer on gitlab.com moves too.
The Firefox behavior:
https://youtu.be/-UyHgPqFM8A
Here you can see, when I the mouse pointer, the comment pointer is not moving.
Thanks.

Flags: needinfo?(shur1kinsta)

I don't know why I can't reproduce this even on Microsoft Edge, but I will change the status of this bug to new since the expected behaviour is not happening.
Reproducible on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04 x64.

Component: Untriaged → DOM: Events
Product: Firefox → Core

(In reply to Hani Yacoub from comment #5)

I don't know why I can't reproduce this even on Microsoft Edge, but I will change the status of this bug to new since the expected behaviour is not happening.
Reproducible on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04 x64.

Have you put your mouse pointer to the comment icon, then held left mouse button and drag the mouse?

It's an official gitlab info about this update: https://about.gitlab.com/releases/2021/01/22/gitlab-13-8-released/#click-and-drag-multiline-merge-request-comments
May be you're using previous gitlab versions.

I could repro this by being logged in, on a random merge request: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/33655/diffs

Status: UNCONFIRMED → NEW
Ever confirmed: true

Oh, I lie. It does work, on Nightly at least... Does it work for you in a Nightly build?

Flags: needinfo?(shur1kinsta)

It also worked for me on 87, on Linux.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)

Oh, I lie. It does work, on Nightly at least... Does it work for you in a Nightly build?

No, it does not.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #10)

It also worked for me on 87, on Linux.

Hmm, I remember I have tried to do the same thing on ubuntu a week ago, but it have not worked me too.

Flags: needinfo?(shur1kinsta)

It works now on GitLab Next. I guess it was fixed in the last update.

This sounds like a website issue then.

Please reopen if needed.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: