1704957 - Update private browsing icons

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

The default favicon and the private-browsing-indicator are both different icons to the toolbar button icon (which is being updated in Bug 1702690). They should be updated to use the newly drawn icons.

The doc at https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE provides links to where to find the new icon assets, suggested procedure and tracking spreadsheet for icon updates.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1704957 - Update private browsing icons.

Comment 2

[Will]

Attachment: jumplist icons.png

Please don't forget the Private icon in the jumplist on Windows (as well as the "Open new tab" and "Open new window" icons)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5a5bf494de
Update private browsing icons. r=sfoster,desktop-theme-reviewers,harry

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Will from comment #2)

Created attachment 9217174 [details]
jumplist icons.png

Please don't forget the Private icon in the jumplist on Windows (as well as the "Open new tab" and "Open new window" icons)

These icons were missed in our audit and we're unlikely to get them updated for Firefox 89. Can you file a new bug for these? We'll try to update them as soon as we can get some new icons made (for New Tab and New Window).

Comment 5

[Will]

No problem, just filed it https://bugzilla.mozilla.org/show_bug.cgi?id=1707055

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/de5a5bf494de

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9217077 [details]
Bug 1704957 - Update private browsing icons.

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open a new private window, and see that the icon in the new tab of the window looks good as well as the icon at the end of the toolbar.
  Please test with Dark, Light, Default-dark, Default-light, and Alpenglow themes
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Icon-only change
• String changes made/needed: none

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9217077 [details]
Bug 1704957 - Update private browsing icons.

Approved for 89 beta 5, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3631bd3863e

Comment 10

[Catalin Sasca, QA [:csasca]]

Verified that the Private icon is updated on Firefox 89.0b5 and Firefox 90.0a1 (2021-04-27). Tests were performed on macOS 10.15.7, Ubuntu 20.04 and Windows 10.