Closed Bug 1704970 Opened 2 years ago Closed 2 years ago

Make fxr use toolkit refresh icon

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Type:
task
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- verified

People

(Reporter: mconley, Assigned: sfoster)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-cleanups][proton-icons])

Attachments

(1 file)

Bug 1704970 - Move fxr's refresh icon to its own assets directory. r?dao
48 bytes, text/x-phabricator-request
Details | Review

FxR is using a toolkit/themes/shared/icons/icon-refresh.svg icon here. It should use browser/themes/shared/icons/reload.svg instead.

Priority: -- → P3
Points: --- → 1
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

I'm going to go with ntim's plan from bug 1699631. Its likely FXR could be using the same refresh/reload icon as everything else, but as that is currently unmaintained I want to minimize changes there. FXR is the only user of toolkit/themes/shared/icons/icon-refresh.svg, so I'll move that out of toolkit and do the rest of the consolidation in 1699631.

Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/428ca54c7696
Move fxr's refresh icon to its own assets directory.

https://hg.mozilla.org/mozilla-central/rev/428ca54c7696

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

I was able to find the icon-refresh.svg icon in the chrome\browser\content\browser\fxr\assets folder, I can confirm that this issue is verified as fixed.

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
You need to log in before you can comment on or make changes to this bug.